Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2151763002: SELECT element: Fix a DCHECK failure in optionToBeShown(). (Closed)

Created:
4 years, 5 months ago by tkent
Modified:
4 years, 5 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SELECT element: Fix a DCHECK failure in optionToBeShown(). If a SELECT element had a selected OPTION, but restoreFormControlState() could't find OPTIONs matched to FormControlState, m_lastOnChangeOption had a stale value. Use selectOption() in restoreFormControlState() to update m_lastOnChangeOption. BUG=627833 Committed: https://crrev.com/5af661c7f9993c6fa9827dfddf738825a43264fe Cr-Commit-Position: refs/heads/master@{#405447}

Patch Set 1 #

Patch Set 2 : SELECT element: Fix a DCHECK failure in optionToBeShown(). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -4 lines) Patch
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp View 1 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
tkent
Hattori-san, would you review this please?
4 years, 5 months ago (2016-07-14 05:13:53 UTC) #6
keishi
LGTM
4 years, 5 months ago (2016-07-14 05:38:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151763002/20001
4 years, 5 months ago (2016-07-14 07:40:05 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-14 07:44:17 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 07:44:19 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 07:46:07 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5af661c7f9993c6fa9827dfddf738825a43264fe
Cr-Commit-Position: refs/heads/master@{#405447}

Powered by Google App Engine
This is Rietveld 408576698