third_party/WebKit/Source/core/html/HTMLSelectElement.cpp - Issue 2151763002: SELECT element: Fix a DCHECK failure in optionToBeShown().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

Issue 2151763002: SELECT element: Fix a DCHECK failure in optionToBeShown(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: SELECT element: Fix a DCHECK failure in optionToBeShown(). Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

index d3c46052dc707340038853ccb3fcb20d01e8b351..1ad1e33107624c69cd70be95fdcf56f65a74f0d0 100644

--- a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

@@ -1145,10 +1145,7 @@ void HTMLSelectElement::restoreFormControlState(const FormControlState& state)

if (itemsSize == 0)

return;

- for (auto& item : items) {

- if (isHTMLOptionElement(item))

- toHTMLOptionElement(item)->setSelectedState(false);

- }

+ selectOption(nullptr, DeselectOtherOptions);

// The saved state should have at least one value and an index.

ASSERT(state.valueSize() >= 2);

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp » ('j') | no next file with comments »