Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(52)

Issue 2151743004: Clear stale NavigationParams from HistoryController. (Closed)

Created:
3 years, 1 month ago by Charlie Reis
Modified:
3 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Clear stale NavigationParams from HistoryController. This prevents newly created iframes during a back/forward from targeting the wrong NavigationEntry. BUG=623319 TEST=See bug comment 20 for repro steps. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2144823002 Cr-Commit-Position: refs/heads/master@{#404870} (cherry picked from commit 4d78d33cb1852e7d487f1d327517c4c4044a3ca3) Committed: https://chromium.googlesource.com/chromium/src/+/b59c2a8c8e48cee3b5e59635f4faa9be1dff925f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -5 lines) Patch
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 1 chunk +88 lines, -0 lines 0 comments Download
M content/renderer/history_controller.h View 1 chunk +7 lines, -3 lines 0 comments Download
M content/renderer/history_controller.cc View 3 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Charlie Reis
3 years, 1 month ago (2016-07-14 21:09:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b59c2a8c8e48cee3b5e59635f4faa9be1dff925f.

Powered by Google App Engine
This is Rietveld 408576698