Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(13)

Issue 2144823002: Clear stale NavigationParams from HistoryController. (Closed)

Created:
2 years, 11 months ago by Charlie Reis
Modified:
2 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, mlamouri+watch-content_chromium.org, site-isolation-reviews_chromium.org, Avi (use Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear stale NavigationParams from HistoryController. This prevents newly created iframes during a back/forward from targeting the wrong NavigationEntry. BUG=623319 TEST=See bug comment 20 for repro steps. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/4d78d33cb1852e7d487f1d327517c4c4044a3ca3 Cr-Commit-Position: refs/heads/master@{#404870}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -5 lines) Patch
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 1 chunk +88 lines, -0 lines 0 comments Download
M content/renderer/history_controller.h View 1 chunk +7 lines, -3 lines 0 comments Download
M content/renderer/history_controller.cc View 3 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
Charlie Reis
Avi, can you review? This is a followup to https://codereview.chromium.org/2134493002, based on comments 18-22 on ...
2 years, 11 months ago (2016-07-12 21:06:16 UTC) #3
ncarter (slow)
lgtm
2 years, 11 months ago (2016-07-12 21:16:26 UTC) #6
Avi (use Gerrit)
lgtm
2 years, 11 months ago (2016-07-12 23:17:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144823002/1
2 years, 11 months ago (2016-07-12 23:22:54 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
2 years, 11 months ago (2016-07-13 01:13:20 UTC) #17
commit-bot: I haz the power
2 years, 11 months ago (2016-07-13 01:15:25 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d78d33cb1852e7d487f1d327517c4c4044a3ca3
Cr-Commit-Position: refs/heads/master@{#404870}

Powered by Google App Engine
This is Rietveld 408576698