Pass validated URL to WebContentsObserver::DidFailProvidsionalLoad.

content/browser/web_contents/web_contents_impl.cc

Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 9b445c8815676eb6171b6d95b893621abf2a7478..e06b86a6c16ca8a029451376cf518435f83b8350 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -3226,11 +3226,10 @@ void WebContentsImpl::DidStartProvisionalLoad(
 void WebContentsImpl::DidFailProvisionalLoadWithError(
     RenderFrameHostImpl* render_frame_host,
     const FrameHostMsg_DidFailProvisionalLoadWithError_Params& params) {
-  GURL validated_url(params.url);
   FOR_EACH_OBSERVER(WebContentsObserver,
                     observers_,
                     DidFailProvisionalLoad(render_frame_host,
-                                           validated_url,
+                                           params.url,

[nasko, 2016/07/14 00:39:21]

The validation has been moved to NavigatorImpl::DidFailProvisionalLoadWithError.
Shouldn't we still be passing the validated URL through? I agree the copy isn't
probably needed, but it looks at this point the filtering of the URL is lost :(.

[lazyboy, 2016/07/14 00:48:52]

Right.
Maybe, we can additionally pass validated_url from NavigatorImpl to this
function?
 I agree the copy isn't

[nasko, 2016/07/14 14:22:46]

Let's just modify the method to take the exact params needed instead of the
params struct. This way we can pass the validated URL and the 3 extra params
don't seem a big deal to me.

                                            params.error_code,
                                            params.error_description,
                                            params.was_ignored_by_handler));