Less strict checked state changes and introduce disabled state for content

Less strict checked state changes and introduce disabled state for content

Sometimes, ChromeVox places range on the ancestor of a node that receives checked state changed. Ensure we cover this case when we process a checked state changed event.

Also, in order to announce disabled state uniformly, make the change to add disabled state in the renderer and make enabled state the implicit default.

BUG=625411, 630570
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/545a777dfe3e6410be16517f78f24602a64a55b6
Cr-Commit-Position: refs/heads/master@{#407949}

[David Tseng, 2016-07-13 22:55:53]

Description was changed from

==========
Be less strict when processing checked changed events.







Quit





     **--F1  cl_description6HUZCR   Top L2# Enter a description of the change.
m

BUG=
==========

to

==========
Be less strict when processing checked changed events.







Quit





     **--F1  cl_description6HUZCR   Top L2# Enter a description of the change.
m

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-07-13 23:53:59]

Description was changed from

==========
Be less strict when processing checked changed events.







Quit





     **--F1  cl_description6HUZCR   Top L2# Enter a description of the change.
m

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Less strict checked state changes and introduce disabled state for content

Sometimes, ChromeVox places range on the ancestor of a node that receives
checked state changed. Ensure we cover this case when we process a checked state
changed event.

Also, in order to announce disabled state uniformly, make the change to add
disabled state in the renderer.
==========

[David Tseng, 2016-07-13 23:53:59]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[David Tseng, 2016-07-13 23:54:59]

Description was changed from

==========
Less strict checked state changes and introduce disabled state for content

Sometimes, ChromeVox places range on the ancestor of a node that receives
checked state changed. Ensure we cover this case when we process a checked state
changed event.

Also, in order to announce disabled state uniformly, make the change to add
disabled state in the renderer.
==========

to

==========
Less strict checked state changes and introduce disabled state for content

Sometimes, ChromeVox places range on the ancestor of a node that receives
checked state changed. Ensure we cover this case when we process a checked state
changed event.

Also, in order to announce disabled state uniformly, make the change to add
disabled state in the renderer.

BUG=625411
==========

[dmazzoni, 2016-07-18 04:23:37]

Do we really want both enabled and disabled?

My preference is to make "disabled" the only state flag because it's more rare;
enabled would be the default for almost everything.

https://codereview.chromium.org/2151713002/diff/20001/content/renderer/access...
File content/renderer/accessibility/blink_ax_enum_conversion.cc (right):

https://codereview.chromium.org/2151713002/diff/20001/content/renderer/access...
content/renderer/accessibility/blink_ax_enum_conversion.cc:70: state |= (1 <<
ui::AX_STATE_DISABLED);
nit: indentation

[David Tseng, 2016-07-19 19:16:53]

Description was changed from

==========
Less strict checked state changes and introduce disabled state for content

Sometimes, ChromeVox places range on the ancestor of a node that receives
checked state changed. Ensure we cover this case when we process a checked state
changed event.

Also, in order to announce disabled state uniformly, make the change to add
disabled state in the renderer.

BUG=625411
==========

to

==========
Less strict checked state changes and introduce disabled state for content

Sometimes, ChromeVox places range on the ancestor of a node that receives
checked state changed. Ensure we cover this case when we process a checked state
changed event.

Also, in order to announce disabled state uniformly, make the change to add
disabled state in the renderer.

BUG=625411
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-07-19 19:18:18]

Description was changed from

==========
Less strict checked state changes and introduce disabled state for content

Sometimes, ChromeVox places range on the ancestor of a node that receives
checked state changed. Ensure we cover this case when we process a checked state
changed event.

Also, in order to announce disabled state uniformly, make the change to add
disabled state in the renderer.

BUG=625411
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Less strict checked state changes and introduce disabled state for content

Sometimes, ChromeVox places range on the ancestor of a node that receives
checked state changed. Ensure we cover this case when we process a checked state
changed event.

Also, in order to announce disabled state uniformly, make the change to add
disabled state in the renderer.

BUG=625411
==========

[David Tseng, 2016-07-19 19:18:26]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 19:19:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 19:40:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 19:40:52]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[David Tseng, 2016-07-19 20:30:48]

Description was changed from

==========
Less strict checked state changes and introduce disabled state for content

Sometimes, ChromeVox places range on the ancestor of a node that receives
checked state changed. Ensure we cover this case when we process a checked state
changed event.

Also, in order to announce disabled state uniformly, make the change to add
disabled state in the renderer.

BUG=625411
==========

to

==========
Less strict checked state changes and introduce disabled state for content

Sometimes, ChromeVox places range on the ancestor of a node that receives
checked state changed. Ensure we cover this case when we process a checked state
changed event.

Also, in order to announce disabled state uniformly, make the change to add
disabled state in the renderer.

BUG=625411
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-07-19 20:31:03]

PTAL. Removed AX_STATE_ENABLED entirely as discussed offline.

[David Tseng, 2016-07-19 20:32:04]

Description was changed from

==========
Less strict checked state changes and introduce disabled state for content

Sometimes, ChromeVox places range on the ancestor of a node that receives
checked state changed. Ensure we cover this case when we process a checked state
changed event.

Also, in order to announce disabled state uniformly, make the change to add
disabled state in the renderer.

BUG=625411
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Less strict checked state changes and introduce disabled state for content

Sometimes, ChromeVox places range on the ancestor of a node that receives
checked state changed. Ensure we cover this case when we process a checked state
changed event.

Also, in order to announce disabled state uniformly, make the change to add
disabled state in the renderer and make enabled state implicit.

BUG=625411
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-07-19 20:32:29]

Description was changed from

==========
Less strict checked state changes and introduce disabled state for content

Sometimes, ChromeVox places range on the ancestor of a node that receives
checked state changed. Ensure we cover this case when we process a checked state
changed event.

Also, in order to announce disabled state uniformly, make the change to add
disabled state in the renderer and make enabled state implicit.

BUG=625411
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Less strict checked state changes and introduce disabled state for content

Sometimes, ChromeVox places range on the ancestor of a node that receives
checked state changed. Ensure we cover this case when we process a checked state
changed event.

Also, in order to announce disabled state uniformly, make the change to add
disabled state in the renderer and make enabled state the implicit default.

BUG=625411
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dmazzoni, 2016-07-19 20:34:35]

lgtm

https://codereview.chromium.org/2151713002/diff/60001/chrome/common/extension...
File chrome/common/extensions/api/automation.idl (right):

https://codereview.chromium.org/2151713002/diff/60001/chrome/common/extension...
chrome/common/extensions/api/automation.idl:193: enabled,
Can you delete this now?

[David Tseng, 2016-07-26 16:56:57]

Description was changed from

==========
Less strict checked state changes and introduce disabled state for content

Sometimes, ChromeVox places range on the ancestor of a node that receives
checked state changed. Ensure we cover this case when we process a checked state
changed event.

Also, in order to announce disabled state uniformly, make the change to add
disabled state in the renderer and make enabled state the implicit default.

BUG=625411
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Less strict checked state changes and introduce disabled state for content

Sometimes, ChromeVox places range on the ancestor of a node that receives
checked state changed. Ensure we cover this case when we process a checked state
changed event.

Also, in order to announce disabled state uniformly, make the change to add
disabled state in the renderer and make enabled state the implicit default.

BUG=625411,630570
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-07-26 21:02:41]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-07-26 21:02:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2151713002/#ps120001
(title: "Fix tests.")

[commit-bot: I haz the power, 2016-07-26 21:03:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Tseng, 2016-07-26 21:33:04]

The CQ bit was unchecked by dtseng@chromium.org

[David Tseng, 2016-07-26 21:39:51]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-07-26 21:39:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2151713002/#ps140001
(title: "m")

[commit-bot: I haz the power, 2016-07-26 21:40:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 22:47:17]

Description was changed from

==========
Less strict checked state changes and introduce disabled state for content

Sometimes, ChromeVox places range on the ancestor of a node that receives
checked state changed. Ensure we cover this case when we process a checked state
changed event.

Also, in order to announce disabled state uniformly, make the change to add
disabled state in the renderer and make enabled state the implicit default.

BUG=625411,630570
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Less strict checked state changes and introduce disabled state for content

Sometimes, ChromeVox places range on the ancestor of a node that receives
checked state changed. Ensure we cover this case when we process a checked state
changed event.

Also, in order to announce disabled state uniformly, make the change to add
disabled state in the renderer and make enabled state the implicit default.

BUG=625411,630570
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-07-26 22:47:19]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-07-26 22:48:55]

Description was changed from

==========
Less strict checked state changes and introduce disabled state for content

Sometimes, ChromeVox places range on the ancestor of a node that receives
checked state changed. Ensure we cover this case when we process a checked state
changed event.

Also, in order to announce disabled state uniformly, make the change to add
disabled state in the renderer and make enabled state the implicit default.

BUG=625411,630570
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Less strict checked state changes and introduce disabled state for content

Sometimes, ChromeVox places range on the ancestor of a node that receives
checked state changed. Ensure we cover this case when we process a checked state
changed event.

Also, in order to announce disabled state uniformly, make the change to add
disabled state in the renderer and make enabled state the implicit default.

BUG=625411,630570
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/545a777dfe3e6410be16517f78f24602a64a55b6
Cr-Commit-Position: refs/heads/master@{#407949}
==========

[commit-bot: I haz the power, 2016-07-26 22:48:57]

Patchset 8 (id:??) landed as
https://crrev.com/545a777dfe3e6410be16517f78f24602a64a55b6
Cr-Commit-Position: refs/heads/master@{#407949}