content/browser/accessibility/browser_accessibility_win_unittest.cc - Issue 2151713002: Less strict checked state changes and introduce disabled state for content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_win_unittest.cc

Issue 2151713002: Less strict checked state changes and introduce disabled state for content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: m Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_win.cc ('k') | content/renderer/accessibility/blink_ax_enum_conversion.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_win_unittest.cc

diff --git a/content/browser/accessibility/browser_accessibility_win_unittest.cc b/content/browser/accessibility/browser_accessibility_win_unittest.cc

index 206f29a08d7ba9cb29d9d37907ad6c424dcf434a..8e0a59e5b2b7e4b4f65c7325d7b5d6d664e9f664 100644

--- a/content/browser/accessibility/browser_accessibility_win_unittest.cc

+++ b/content/browser/accessibility/browser_accessibility_win_unittest.cc

@@ -732,7 +732,6 @@ TEST_F(BrowserAccessibilityTest, TestCreateEmptyDocument) {

CountedBrowserAccessibility::reset();

const int32_t busy_state = 1 << ui::AX_STATE_BUSY;

const int32_t readonly_state = 1 << ui::AX_STATE_READ_ONLY;

- const int32_t enabled_state = 1 << ui::AX_STATE_ENABLED;

std::unique_ptr<BrowserAccessibilityManager> manager(

new BrowserAccessibilityManagerWin(

BrowserAccessibilityManagerWin::GetEmptyDocument(), nullptr,

@@ -742,7 +741,7 @@ TEST_F(BrowserAccessibilityTest, TestCreateEmptyDocument) {

BrowserAccessibility* root = manager->GetRoot();

EXPECT_EQ(0, root->GetId());

EXPECT_EQ(ui::AX_ROLE_ROOT_WEB_AREA, root->GetRole());

- EXPECT_EQ(busy_state | readonly_state | enabled_state, root->GetState());

+ EXPECT_EQ(busy_state | readonly_state, root->GetState());

// Tree with a child textfield.

ui::AXNodeData tree1_1;

@@ -822,9 +821,7 @@ TEST_F(BrowserAccessibilityTest, EmptyDocHasUniqueIdWin) {

BrowserAccessibility* root = manager->GetRoot();

EXPECT_EQ(0, root->GetId());

EXPECT_EQ(ui::AX_ROLE_ROOT_WEB_AREA, root->GetRole());

- EXPECT_EQ(1 << ui::AX_STATE_BUSY |

- 1 << ui::AX_STATE_READ_ONLY |

- 1 << ui::AX_STATE_ENABLED,

+ EXPECT_EQ(1 << ui::AX_STATE_BUSY | 1 << ui::AX_STATE_READ_ONLY,

root->GetState());

int32_t unique_id = ToBrowserAccessibilityWin(root)->unique_id();