chrome/test/data/extensions/api_test/bindings/iframe_before_navigate.html - Issue 2151693002: Fix extension bindings injection for iframes

Unified Diff: chrome/test/data/extensions/api_test/bindings/iframe_before_navigate.html

Issue 2151693002: Fix extension bindings injection for iframes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/extensions/api_test/bindings/external_message_listener/background.js ('K') | « chrome/test/data/extensions/api_test/bindings/external_message_listener/manifest.json ('k') | chrome/test/data/extensions/api_test/bindings/message_sender/background.js » ('j') | extensions/renderer/script_context_set.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/bindings/iframe_before_navigate.html

diff --git a/chrome/test/data/extensions/api_test/bindings/iframe_before_navigate.html b/chrome/test/data/extensions/api_test/bindings/iframe_before_navigate.html

new file mode 100644

index 0000000000000000000000000000000000000000..b5f957a3834722a2766b32177ca6233c2145d041

--- /dev/null

+++ b/chrome/test/data/extensions/api_test/bindings/iframe_before_navigate.html

@@ -0,0 +1,22 @@

+<!doctype html>

+<html>

+<body>

+<iframe id="frame" src="chrome-extension://ficgdghpakbhhkmdjamiedmcoobamkoo/public.html"></iframe>

+<script>

Devlin 2016/07/14 16:46:35 due to the semi-ambiguous ordering of when blink c

asargent_no_longer_on_chrome 2016/07/20 21:36:47 Done. Also added tests of existent/nonexisting pag

+var didRun = false;

+var id;

+var frame = document.getElementById("frame");

+try {

+ id = frame.contentWindow.eval("chrome.runtime.id");

+ frame.contentWindow.eval("chrome.runtime.sendMessage(" +

+ "'mlmdejkkkhmhchpmepehbcncoalclded', 'evil')");

+} catch (e) {}

+didRun = true;

+function getResult() {

+ window.domAutomationController.send(didRun && typeof(id) == "undefined");

Devlin 2016/07/14 16:46:35 typeof is an operator, not a function, so this sho

asargent_no_longer_on_chrome 2016/07/20 21:36:47 Done.

+</script>

+</body>

+</html>