chrome/test/data/extensions/api_test/bindings/iframe_before_navigate.html - Issue 2151693002: Fix extension bindings injection for iframes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/bindings/iframe_before_navigate.html

Issue 2151693002: Fix extension bindings injection for iframes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/test/data/extensions/api_test/bindings/external_message_listener/background.js ('K') | « chrome/test/data/extensions/api_test/bindings/external_message_listener/manifest.json ('k') | chrome/test/data/extensions/api_test/bindings/message_sender/background.js » ('j') | extensions/renderer/script_context_set.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html>

	3 <body>

	4 <iframe id="frame" src="chrome-extension://ficgdghpakbhhkmdjamiedmcoobamkoo/publ ic.html"></iframe>

	5 <script>
	Devlin 2016/07/14 16:46:35 due to the semi-ambiguous ordering of when blink c due to the semi-ambiguous ordering of when blink creates the document vs executes the script, it might be worth also adding a test for an iframe that's created directly in the script tag. Otherwise, it might be possible that by the time the script runs, the iframe has already navigated from about:blank. It could also be worth trying with a frame that points to a non-existent resource, since we've had bugs around treating them differently. I'd probably just have four frames, one real and fake resource for each specified in the document and created in the script, and then try with all of them. None of them should succeed. asargent_no_longer_on_chrome 2016/07/20 21:36:47 Done. Also added tests of existent/nonexisting pag Show quoted text On 2016/07/14 16:46:35, Devlin wrote: > due to the semi-ambiguous ordering of when blink creates the document vs > executes the script, it might be worth also adding a test for an iframe that's > created directly in the script tag. Otherwise, it might be possible that by the > time the script runs, the iframe has already navigated from about:blank. > > It could also be worth trying with a frame that points to a non-existent > resource, since we've had bugs around treating them differently. I'd probably > just have four frames, one real and fake resource for each specified in the > document and created in the script, and then try with all of them. None of them > should succeed. Done. Also added tests of existent/nonexisting pages opened via window.open.
	6 var didRun = false;

	7 var id;

	8 var frame = document.getElementById("frame");

	9 try {

	10 id = frame.contentWindow.eval("chrome.runtime.id");

	11 frame.contentWindow.eval("chrome.runtime.sendMessage(" +

	12 "'mlmdejkkkhmhchpmepehbcncoalclded', 'evil')");

	13 } catch (e) {}

	14 didRun = true;

	15

	16 function getResult() {

	17 window.domAutomationController.send(didRun && typeof(id) == "undefined");
	Devlin 2016/07/14 16:46:35 typeof is an operator, not a function, so this sho typeof is an operator, not a function, so this should be "typeof id" asargent_no_longer_on_chrome 2016/07/20 21:36:47 Done. Show quoted text On 2016/07/14 16:46:35, Devlin wrote: > typeof is an operator, not a function, so this should be "typeof id" Done.
	18 }

	19

	20 </script>

	21 </body>

	22 </html>

OLD	NEW