Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

Issue 2151653005: DevTools: Do not linkify to pseudo (program) node when there's no URL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressing comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
index 21471d7924f7a6ca14ebe64eaa8873000ce5ac8c..561ed3398a1fbe0a0ec4071f291fc7efa0ecdc50 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
@@ -82,11 +82,11 @@ WebInspector.TimelineTreeView.prototype = {
/**
* @param {!RuntimeAgent.CallFrame} frame
- * @return {!Element}
+ * @return {?Element}
*/
linkifyLocation: function(frame)
{
- return this._linkifier.linkifyConsoleCallFrameForTimeline(this._model.target(), frame);
+ return this._linkifier.maybeLinkifyConsoleCallFrameForTimeline(this._model.target(), frame);
},
/**
@@ -347,7 +347,9 @@ WebInspector.TimelineTreeView.GridNode.prototype = {
var frame = WebInspector.TimelineProfileTree.eventStackFrame(event);
if (frame && frame["url"]) {
var callFrame = /** @type {!RuntimeAgent.CallFrame} */ (frame);
- container.createChild("div", "activity-link").appendChild(this._treeView.linkifyLocation(callFrame));
+ var link = this._treeView.linkifyLocation(callFrame);
+ if (link)
+ container.createChild("div", "activity-link").appendChild(link);
}
icon.style.backgroundColor = WebInspector.TimelineUIUtils.eventColor(event);
}

Powered by Google App Engine
This is Rietveld 408576698