third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js - Issue 2151653005: DevTools: Do not linkify to pseudo (program) node when there's no URL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js

Issue 2151653005: DevTools: Do not linkify to pseudo (program) node when there's no URL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js

diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js b/third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js

index c244cf00e0aa6ab4d973adfe5b2be4066a0d8469..0ad215db5d3d430599e4778fbab8c0df75ae3736 100644

--- a/third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js

+++ b/third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js

@@ -80,6 +80,8 @@ WebInspector.ProfileDataGridNode.prototype = {

if (this.profileNode.scriptId === "0")

break;

var urlElement = this.tree._formatter.linkifyNode(this);

+ if (!urlElement)

+ break;

urlElement.style.maxWidth = "75%";

cell.appendChild(urlElement);

break;

@@ -648,7 +650,7 @@ WebInspector.ProfileDataGridNode.Formatter.prototype = {

/**

* @param {!WebInspector.ProfileDataGridNode} node

- * @return {!Element}

+ * @return {?Element}

linkifyNode: function(node) { }

}