DevTools: Do not linkify to pseudo (program) node when there's no URL

DevTools: Do not linkify to pseudo (program) node when there's no URL

Just omit the link instead.

NOTRY=true

Committed: https://crrev.com/bcbc44a685a6362d9a0100cf1422f03364e5494e
Cr-Commit-Position: refs/heads/master@{#406140}

[alph, 2016-07-15 21:02:17]

The CQ bit was checked by alph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 21:02:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alph, 2016-07-15 21:03:17]

alph@chromium.org changed reviewers:
+ caseq@chromium.org

[caseq, 2016-07-15 21:18:24]

caseq@chromium.org changed reviewers:
+ dgozman@chromium.org

[caseq, 2016-07-15 21:18:25]

lgtm as long as dgozman is ok.

[alph, 2016-07-15 22:05:23]

Dmitry could you please?

[alph, 2016-07-15 22:05:52]

The CQ bit was checked by alph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 22:06:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-07-15 23:24:22]

We have too many clients which will have to be careful now. Let's use
maybeLinkify methods?

https://codereview.chromium.org/2151653005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
(right):

https://codereview.chromium.org/2151653005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:165:
linkifyScriptLocation: function(target, scriptId, sourceURL, lineNumber,
columnNumber, classes)
This is used in ConsoleViewMessage._tryFormatAsError,
NetworkDataGridNode._renderInitiatorCell,
HeapSnapshotView._didReceiveAllocationStack, AllocationGridNode.createCell and
ServiceWorkersView._addError.

https://codereview.chromium.org/2151653005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:174: var
rawLocation = scriptId && scriptId !== "0"
Let's rather fix backend to send empty string or better not send scriptId at
all.

https://codereview.chromium.org/2151653005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:195:
linkifyRawLocation: function(rawLocation, fallbackUrl, classes)
This is used in ObjectPopoverHelper._showObjectPopover.

[alph, 2016-07-16 01:29:27]

Addressed comments. ptal

[dgozman, 2016-07-16 20:34:39]

https://codereview.chromium.org/2151653005/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js
(right):

https://codereview.chromium.org/2151653005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js:241:
row.createChild("td").textContent = " @ ";
I think it would still be useful to see "url:lineNumber" text even if we cannot
point to any resource.

https://codereview.chromium.org/2151653005/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
(right):

https://codereview.chromium.org/2151653005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:221:
linkifyConsoleCallFrame: function(target, callFrame, classes)
maybeLinkify...

https://codereview.chromium.org/2151653005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:232:
linkifyConsoleCallFrameForTimeline: function(target, callFrame, classes)
maybeLinkify...

https://codereview.chromium.org/2151653005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:553: var
linkText = urlDisplayName ? urlDisplayName : url ?
WebInspector.displayNameForURL(url) : WebInspector.UIString("(program)");
Let's return empty element instead of "(program)"? Or just a span with
"url:lineNumber" text instead of a link. That was the initial goal of the patch,
right?

[alph, 2016-07-18 19:28:54]

ptal

https://codereview.chromium.org/2151653005/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js
(right):

https://codereview.chromium.org/2151653005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js:241:
row.createChild("td").textContent = " @ ";
On 2016/07/16 20:34:39, dgozman wrote:
> I think it would still be useful to see "url:lineNumber" text even if we
cannot
> point to any resource.

Agree. Done that in maybeLinkifyScriptLocation

https://codereview.chromium.org/2151653005/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
(right):

https://codereview.chromium.org/2151653005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:221:
linkifyConsoleCallFrame: function(target, callFrame, classes)
On 2016/07/16 20:34:39, dgozman wrote:
> maybeLinkify...

Done.

https://codereview.chromium.org/2151653005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:232:
linkifyConsoleCallFrameForTimeline: function(target, callFrame, classes)
On 2016/07/16 20:34:39, dgozman wrote:
> maybeLinkify...

Done.

https://codereview.chromium.org/2151653005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:553: var
linkText = urlDisplayName ? urlDisplayName : url ?
WebInspector.displayNameForURL(url) : WebInspector.UIString("(program)");
On 2016/07/16 20:34:39, dgozman wrote:
> Let's return empty element instead of "(program)"? Or just a span with
> "url:lineNumber" text instead of a link. That was the initial goal of the
patch,
> right?

Empty element would be weird, as some clients might still print something like
"foo @ link"
How about keep a static placeholder, e.g. (unknown).

[dgozman, 2016-07-18 19:42:17]

lgtm. Thank you for making this better!

[alph, 2016-07-18 19:44:15]

The CQ bit was checked by alph@chromium.org

[alph, 2016-07-18 19:44:16]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2151653005/#ps80001
(title: "addressing comments")

[commit-bot: I haz the power, 2016-07-18 19:45:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 23:07:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 23:07:57]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[alph, 2016-07-18 23:27:34]

Description was changed from

==========
DevTools: Do not linkify to pseudo (program) node when there's no URL

Just omit the link instead.
==========

to

==========
DevTools: Do not linkify to pseudo (program) node when there's no URL

Just omit the link instead.

NOTRY=true
==========

[alph, 2016-07-18 23:27:40]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2016-07-18 23:28:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 23:40:10]

Description was changed from

==========
DevTools: Do not linkify to pseudo (program) node when there's no URL

Just omit the link instead.

NOTRY=true
==========

to

==========
DevTools: Do not linkify to pseudo (program) node when there's no URL

Just omit the link instead.

NOTRY=true
==========

[commit-bot: I haz the power, 2016-07-18 23:40:11]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-18 23:40:19]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-18 23:43:11]

Description was changed from

==========
DevTools: Do not linkify to pseudo (program) node when there's no URL

Just omit the link instead.

NOTRY=true
==========

to

==========
DevTools: Do not linkify to pseudo (program) node when there's no URL

Just omit the link instead.

NOTRY=true

Committed: https://crrev.com/bcbc44a685a6362d9a0100cf1422f03364e5494e
Cr-Commit-Position: refs/heads/master@{#406140}
==========

[commit-bot: I haz the power, 2016-07-18 23:43:12]

Patchset 5 (id:??) landed as
https://crrev.com/bcbc44a685a6362d9a0100cf1422f03364e5494e
Cr-Commit-Position: refs/heads/master@{#406140}