Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2151653003: Convert some GN test support targets to static libs. (Closed)

Created:
4 years, 5 months ago by brettw
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, vabr+watchlistpasswordmanager_chromium.org, jam, dcheng, darin-cc_chromium.org, cc-bugs_chromium.org, scheduler-bugs_chromium.org, gcasto+watchlist_chromium.org, sync-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert some GN test support targets to static libs. Converts some source sets that were source sets into static libraries. Converts additional targets in the touched files to static libraries where it seemed relevant. Update the definition of //crypto:test_support to mark it testonly and make the conditions append sources rather than subtract them in the reverse condition. A few redundant dependencies were removed (one shouldn't need to specify both "foo" and "foo:test_support"). BUG=627637 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel Committed: https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c Cr-Commit-Position: refs/heads/master@{#405544}

Patch Set 1 #

Patch Set 2 : crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -67 lines) Patch
M cc/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/open_from_clipboard/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/os_crypt/BUILD.gn View 3 chunks +3 lines, -6 lines 0 comments Download
M components/password_manager/core/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/pref_registry/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/prefs/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/printing/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/cryptauth/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/safe_json/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/scheduler/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/search_engines/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/signin/core/browser/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/storage_monitor/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/subresource_filter/core/browser/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync_driver/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync_sessions/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/syncable_prefs/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/toolbar/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/update_client/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/user_prefs/tracked/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/webdata_services/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/zoom/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/BUILD.gn View 3 chunks +2 lines, -3 lines 0 comments Download
M crypto/BUILD.gn View 1 1 chunk +13 lines, -17 lines 0 comments Download
M dbus/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M device/usb/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
brettw
4 years, 5 months ago (2016-07-14 17:56:10 UTC) #3
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-14 18:25:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151653003/20001
4 years, 5 months ago (2016-07-14 18:32:59 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-14 19:39:15 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 19:39:19 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 19:42:13 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c
Cr-Commit-Position: refs/heads/master@{#405544}

Powered by Google App Engine
This is Rietveld 408576698