Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2348)

Unified Diff: crypto/BUILD.gn

Issue 2151653003: Convert some GN test support targets to static libs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: crypto Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/BUILD.gn ('k') | dbus/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: crypto/BUILD.gn
diff --git a/crypto/BUILD.gn b/crypto/BUILD.gn
index 088a5c131b7f73acaa3d4fd1d4b9042c2b3c124f..a912d934c506c2ec6c13abf7281a41ca0473a76f 100644
--- a/crypto/BUILD.gn
+++ b/crypto/BUILD.gn
@@ -175,36 +175,32 @@ test("crypto_unittests") {
]
}
+# This has no sources in some cases so can't be a static library.
source_set("test_support") {
- sources = [
- "scoped_test_nss_chromeos_user.cc",
- "scoped_test_nss_chromeos_user.h",
- "scoped_test_nss_db.cc",
- "scoped_test_nss_db.h",
- "scoped_test_system_nss_key_slot.cc",
- "scoped_test_system_nss_key_slot.h",
- ]
- deps = [
- ":crypto",
- ":platform",
- "//base",
- ]
+ testonly = true
+ sources = []
- if (!use_nss_certs) {
- sources -= [
+ if (use_nss_certs) {
+ sources += [
"scoped_test_nss_db.cc",
"scoped_test_nss_db.h",
]
}
- if (!is_chromeos) {
- sources -= [
+ if (is_chromeos) {
+ sources += [
"scoped_test_nss_chromeos_user.cc",
"scoped_test_nss_chromeos_user.h",
"scoped_test_system_nss_key_slot.cc",
"scoped_test_system_nss_key_slot.h",
]
}
+
+ deps = [
+ ":crypto",
+ ":platform",
+ "//base",
+ ]
}
config("platform_config") {
« no previous file with comments | « content/test/BUILD.gn ('k') | dbus/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698