Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2151643002: Revert of Revive experiment to isolate shell operations. (Closed)

Created:
4 years, 5 months ago by nektarios
Modified:
4 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revive experiment to isolate shell operations. (patchset #5 id:100001 of https://codereview.chromium.org/2122303002/ ) Reason for revert: Possibly broke compile on"Win8 GYP (dbg)" Original issue's description: > Isolate shell operations to the utility process. > > Shell operations can cause 3rd-party shell extensions to be > loaded into the caller's process. The utility process protects the browser process from potential instability. > > Also convert the IPC mechanism to Mojo. > > BUG=73098 > > Committed: https://crrev.com/b7faec8d94ef286d2b92144c2836b170c2cdea95 > Cr-Commit-Position: refs/heads/master@{#405270} TBR=sky@chromium.org,dcheng@chromium.org,wfh@chromium.org,pmonette@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=73098

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+493 lines, -315 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/win/chrome_select_file_dialog_factory.h View 3 chunks +11 lines, -1 line 0 comments Download
M chrome/browser/win/chrome_select_file_dialog_factory.cc View 1 chunk +283 lines, -165 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_utility.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/common/chrome_utility_messages.h View 5 chunks +55 lines, -0 lines 0 comments Download
M chrome/common/shell_handler_win.mojom View 1 chunk +1 line, -46 lines 0 comments Download
D chrome/common/shell_handler_win.typemap View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/common/typemaps.gni View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/utility/chrome_content_utility_client.cc View 2 chunks +5 lines, -0 lines 0 comments Download
A chrome/utility/ipc_shell_handler_win.h View 1 chunk +53 lines, -0 lines 0 comments Download
A chrome/utility/ipc_shell_handler_win.cc View 1 chunk +79 lines, -0 lines 0 comments Download
M chrome/utility/shell_handler_impl_win.h View 2 chunks +0 lines, -21 lines 0 comments Download
M chrome/utility/shell_handler_impl_win.cc View 2 chunks +0 lines, -58 lines 0 comments Download
M mojo/public/tools/bindings/chromium_bindings_configuration.gni View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
nektarios
Created Revert of Revive experiment to isolate shell operations.
4 years, 5 months ago (2016-07-13 21:10:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151643002/1
4 years, 5 months ago (2016-07-13 21:11:29 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 21:13:17 UTC) #5
Failed to apply patch for chrome/common/shell_handler_win.typemap:
While running git rm chrome/common/shell_handler_win.typemap;
  fatal: pathspec 'chrome/common/shell_handler_win.typemap' did not match any
files

Patch:  D    chrome/common/shell_handler_win.typemap
Index: chrome/common/shell_handler_win.typemap
diff --git a/chrome/common/shell_handler_win.typemap
b/chrome/common/shell_handler_win.typemap
deleted file mode 100644
index
b7b108439fdae363265b90c1f6e3398f3e125503..0000000000000000000000000000000000000000
--- a/chrome/common/shell_handler_win.typemap
+++ /dev/null
@@ -1,11 +0,0 @@
-# Copyright 2016 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-mojom = "//chrome/common/shell_handler_win.mojom"
-public_headers = [ "//base/strings/string16.h" ]
-deps = [
-  "//base",
-]
-type_mappings = [ "mojom.FileExtensionFilters=" +
-                  "std::vector<std::tuple<base::string16, base::string16>>" ]

Powered by Google App Engine
This is Rietveld 408576698