Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2151563003: Revert of [Turbofan] Change AlignSavedCalleeRegisterSlots to AlignFrame. (Closed)

Created:
4 years, 5 months ago by bbudge
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Turbofan] Change AlignSavedCalleeRegisterSlots to AlignFrame. (patchset #2 id:20001 of https://codereview.chromium.org/2124983004/ ) Reason for revert: Speculative revert to fix perf regression: https://bugs.chromium.org/p/chromium/issues/detail?id=627803 Original issue's description: > [Turbofan] Change AlignSavedCalleeRegisterSlots to AlignFrame. > Clean up call sites. > > LOG=N > BUG=v8:4124 > > Committed: https://crrev.com/d8d75782fb90da21b92ca3dda59cfa3088ad3912 > Cr-Commit-Position: refs/heads/master@{#37650} TBR=bmeurer@chromium.org,mtrofin@chromium.org,danno@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:4124 Committed: https://crrev.com/a6ffe8efe1699ca06396c0885bd8272e45162987 Cr-Commit-Position: refs/heads/master@{#37732}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -10 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/compiler/frame.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/s390/code-generator-s390.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +13 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
bbudge
Created Revert of [Turbofan] Change AlignSavedCalleeRegisterSlots to AlignFrame.
4 years, 5 months ago (2016-07-13 22:37:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151563003/1
4 years, 5 months ago (2016-07-13 22:37:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 23:00:45 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 23:02:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6ffe8efe1699ca06396c0885bd8272e45162987
Cr-Commit-Position: refs/heads/master@{#37732}

Powered by Google App Engine
This is Rietveld 408576698