Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Side by Side Diff: src/compiler/arm/code-generator-arm.cc

Issue 2151563003: Revert of [Turbofan] Change AlignSavedCalleeRegisterSlots to AlignFrame. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/compiler/frame.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/code-generator.h" 5 #include "src/compiler/code-generator.h"
6 6
7 #include "src/arm/macro-assembler-arm.h" 7 #include "src/arm/macro-assembler-arm.h"
8 #include "src/ast/scopes.h" 8 #include "src/ast/scopes.h"
9 #include "src/compiler/code-generator-impl.h" 9 #include "src/compiler/code-generator-impl.h"
10 #include "src/compiler/gap-resolver.h" 10 #include "src/compiler/gap-resolver.h"
(...skipping 1541 matching lines...) Expand 10 before | Expand all | Expand 10 after
1552 __ Call(deopt_entry, RelocInfo::RUNTIME_ENTRY); 1552 __ Call(deopt_entry, RelocInfo::RUNTIME_ENTRY);
1553 __ CheckConstPool(false, false); 1553 __ CheckConstPool(false, false);
1554 return kSuccess; 1554 return kSuccess;
1555 } 1555 }
1556 1556
1557 void CodeGenerator::FinishFrame(Frame* frame) { 1557 void CodeGenerator::FinishFrame(Frame* frame) {
1558 CallDescriptor* descriptor = linkage()->GetIncomingDescriptor(); 1558 CallDescriptor* descriptor = linkage()->GetIncomingDescriptor();
1559 1559
1560 const RegList saves_fp = descriptor->CalleeSavedFPRegisters(); 1560 const RegList saves_fp = descriptor->CalleeSavedFPRegisters();
1561 if (saves_fp != 0) { 1561 if (saves_fp != 0) {
1562 frame->AlignFrame(); 1562 frame->AlignSavedCalleeRegisterSlots();
1563 }
1564
1565 if (saves_fp != 0) {
1563 // Save callee-saved FP registers. 1566 // Save callee-saved FP registers.
1564 STATIC_ASSERT(DwVfpRegister::kMaxNumRegisters == 32); 1567 STATIC_ASSERT(DwVfpRegister::kMaxNumRegisters == 32);
1565 uint32_t last = base::bits::CountLeadingZeros32(saves_fp) - 1; 1568 uint32_t last = base::bits::CountLeadingZeros32(saves_fp) - 1;
1566 uint32_t first = base::bits::CountTrailingZeros32(saves_fp); 1569 uint32_t first = base::bits::CountTrailingZeros32(saves_fp);
1567 DCHECK_EQ((last - first + 1), base::bits::CountPopulation32(saves_fp)); 1570 DCHECK_EQ((last - first + 1), base::bits::CountPopulation32(saves_fp));
1568 frame->AllocateSavedCalleeRegisterSlots((last - first + 1) * 1571 frame->AllocateSavedCalleeRegisterSlots((last - first + 1) *
1569 (kDoubleSize / kPointerSize)); 1572 (kDoubleSize / kPointerSize));
1570 } 1573 }
1571 const RegList saves = FLAG_enable_embedded_constant_pool 1574 const RegList saves = FLAG_enable_embedded_constant_pool
1572 ? (descriptor->CalleeSavedRegisters() & ~pp.bit()) 1575 ? (descriptor->CalleeSavedRegisters() & ~pp.bit())
(...skipping 361 matching lines...) Expand 10 before | Expand all | Expand 10 after
1934 padding_size -= v8::internal::Assembler::kInstrSize; 1937 padding_size -= v8::internal::Assembler::kInstrSize;
1935 } 1938 }
1936 } 1939 }
1937 } 1940 }
1938 1941
1939 #undef __ 1942 #undef __
1940 1943
1941 } // namespace compiler 1944 } // namespace compiler
1942 } // namespace internal 1945 } // namespace internal
1943 } // namespace v8 1946 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/compiler/frame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698