Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2151543002: Get rid of GetPreferredTryMasters that just loads cq.cfg. (Closed)

Created:
4 years, 5 months ago by tandrii(chromium)
Modified:
4 years, 5 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of GetPreferredTryMasters that just loads cq.cfg. git cl try now schedules CQ dry run by default. BUG=577224 R=sergiyb@chromium.org,phajdan.jr@chromium.org Committed: https://crrev.com/59e892df1075b0d1e58cfa321398d9e6e13020be Cr-Commit-Position: refs/heads/master@{#405218}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M third_party/WebKit/PRESUBMIT.py View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
tandrii(chromium)
4 years, 5 months ago (2016-07-13 15:35:21 UTC) #1
Paweł Hajdan Jr.
LGTM
4 years, 5 months ago (2016-07-13 15:42:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151543002/1
4 years, 5 months ago (2016-07-13 15:55:03 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/217263)
4 years, 5 months ago (2016-07-13 16:04:19 UTC) #9
tandrii(chromium)
+dpranke for owner LGTM
4 years, 5 months ago (2016-07-13 16:13:58 UTC) #11
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-13 16:32:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151543002/1
4 years, 5 months ago (2016-07-13 16:36:02 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 17:57:28 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 17:59:22 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59e892df1075b0d1e58cfa321398d9e6e13020be
Cr-Commit-Position: refs/heads/master@{#405218}

Powered by Google App Engine
This is Rietveld 408576698