Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: third_party/WebKit/PRESUBMIT.py

Issue 2151543002: Get rid of GetPreferredTryMasters that just loads cq.cfg. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/PRESUBMIT.py
diff --git a/third_party/WebKit/PRESUBMIT.py b/third_party/WebKit/PRESUBMIT.py
index 5f060cc805d4d3c4d249804bd1c8cfc695f3cc0f..cee4638e6e81de47436fa975eb0c69f3a02cc65c 100644
--- a/third_party/WebKit/PRESUBMIT.py
+++ b/third_party/WebKit/PRESUBMIT.py
@@ -320,30 +320,3 @@ def CheckChangeOnCommit(input_api, output_api):
results.extend(input_api.canned_checks.CheckChangeHasDescription(
input_api, output_api))
return results
-
-
-def GetPreferredTryMasters(project, change):
- import json
- import os.path
- import platform
- import subprocess
-
- cq_config_path = os.path.join(
- change.RepositoryRoot(), 'infra', 'config', 'cq.cfg')
- # commit_queue.py below is a script in depot_tools directory, which has a
- # 'builders' command to retrieve a list of CQ builders from the CQ config.
- is_win = platform.system() == 'Windows'
- masters = json.loads(subprocess.check_output(
- ['commit_queue', 'builders', cq_config_path], shell=is_win))
-
- try_config = {}
- for master in masters:
- try_config.setdefault(master, {})
- for builder in masters[master]:
- # Do not trigger presubmit builders, since they're likely to fail
- # (e.g. OWNERS checks before finished code review), and we're
- # running local presubmit anyway.
- if 'presubmit' not in builder:
- try_config[master][builder] = ['defaulttests']
-
- return try_config
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698