Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2151523002: Revert of Make components source_sets on Android. (Closed)

Created:
4 years, 5 months ago by Nico
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, Reid Kleckner
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make components source_sets on Android. (patchset #1 id:1 of https://codereview.chromium.org/2137023003/ ) Reason for revert: Speculative, might've broke llvm_force_head_revision=true builds (see comment on the original review). Original issue's description: > Make components source_sets on Android. > > There was a perf regression reported when components were changed from source sets to static libraries in the non-component build. This patch switches back to source sets on Android only to see what happens to thread_times.key_silk_cases and the build performance. > > BUG=619593 > > Committed: https://crrev.com/89248dc70996f9927292a7fee6911715464e1643 > Cr-Commit-Position: refs/heads/master@{#405056} TBR=dpranke@chromium.org,brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=619593 Committed: https://crrev.com/aa5466df6e58dd54bc1dd1a5192f2c52ebf6ff29 Cr-Commit-Position: refs/heads/master@{#405152}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M build/config/BUILDCONFIG.gn View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Nico
Created Revert of Make components source_sets on Android.
4 years, 5 months ago (2016-07-13 15:05:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151523002/1
4 years, 5 months ago (2016-07-13 15:06:11 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 15:06:52 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/aa5466df6e58dd54bc1dd1a5192f2c52ebf6ff29 Cr-Commit-Position: refs/heads/master@{#405152}
4 years, 5 months ago (2016-07-13 15:08:52 UTC) #6
Nico
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2145063002/ by thakis@chromium.org. ...
4 years, 5 months ago (2016-07-13 15:29:31 UTC) #7
Dirk Pranke
4 years, 5 months ago (2016-07-13 16:31:37 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698