Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Unified Diff: build/config/BUILDCONFIG.gn

Issue 2151523002: Revert of Make components source_sets on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/BUILDCONFIG.gn
diff --git a/build/config/BUILDCONFIG.gn b/build/config/BUILDCONFIG.gn
index 2036b3451904718854386ad7b6c6013ebf768033..4f3a223c32d23ab7b79007add5081deac14bdf7e 100644
--- a/build/config/BUILDCONFIG.gn
+++ b/build/config/BUILDCONFIG.gn
@@ -639,14 +639,9 @@
assert(invoker.static_component_type == "static_library" ||
invoker.static_component_type == "source_set")
_component_mode = invoker.static_component_type
- } else if (is_android || !defined(invoker.sources)) {
+ } else if (!defined(invoker.sources)) {
# When there are no sources defined, use a source set to avoid creating
# an empty static library (which generally don't work).
- #
- # TODO(brettw) remove the Android condition or comment why it needs to be
- # kept after some analysis. Source sets vs. static libraries seem to be
- # causing some performance differences. As part of the analysis for
- # http://crbug.com/619593 we're testing source sets for components again.
_component_mode = "source_set"
} else {
_component_mode = "static_library"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698