Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Issue 2151493002: Reland of [turbofan] Do not use the self reference for turbofan functions (Closed)

Created:
4 years, 5 months ago by ahaas
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [turbofan] Do not use the self reference for turbofan functions This CL is just a rebase of the original CL (https://codereview.chromium.org/2150523002). The reason for reverting was: Dependency of the roll unblocking revert https://codereview.chromium.org/2147883003/. Original message: The self reference requires the allocation of a handle in the macro assembler, which is not possible if we instantiate the macro assembler in a worker thread. R=bmeurer@chromium.org Committed: https://crrev.com/778fe89387fe27865b71e0b7aaf37e56c432d4f0 Cr-Commit-Position: refs/heads/master@{#37744}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M src/codegen.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/codegen.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M src/compiler/code-generator.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/crankshaft/lithium.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
ahaas
4 years, 5 months ago (2016-07-13 14:45:42 UTC) #1
Benedikt Meurer
lgtm
4 years, 5 months ago (2016-07-13 17:43:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151493002/1
4 years, 5 months ago (2016-07-14 07:30:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 07:33:13 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 07:34:06 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/778fe89387fe27865b71e0b7aaf37e56c432d4f0
Cr-Commit-Position: refs/heads/master@{#37744}

Powered by Google App Engine
This is Rietveld 408576698