[turbofan] Do not use the self reference for turbofan functions.

[turbofan] Do not use the self reference for turbofan functions.

The self reference requires the allocation of a handle in the macro
assembler, which is not possible if we instantiate the macro assembler
in a worker thread.

R=mstarzinger@chromium.org, bmeurer@chromium.org

Committed: https://crrev.com/49ef529b3af50f5daadacdcdcd6be3a307c10af5
Cr-Commit-Position: refs/heads/master@{#37713}

[ahaas, 2016-07-13 12:38:09]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 12:38:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Starzinger, 2016-07-13 12:42:44]

https://codereview.chromium.org/2150523002/diff/1/src/codegen.cc
File src/codegen.cc (right):

https://codereview.chromium.org/2150523002/diff/1/src/codegen.cc#newcode124
src/codegen.cc:124: bool is_self_ref_available) {
nit: We could pass in the "Handle<Object> self_reference" explicitly. WDYT?

[ahaas, 2016-07-13 12:44:14]

On 2016/07/13 at 12:42:44, mstarzinger wrote:
> https://codereview.chromium.org/2150523002/diff/1/src/codegen.cc
> File src/codegen.cc (right):
> 
> https://codereview.chromium.org/2150523002/diff/1/src/codegen.cc#newcode124
> src/codegen.cc:124: bool is_self_ref_available) {
> nit: We could pass in the "Handle<Object> self_reference" explicitly. WDYT?

I have no opinion on that, whatever you prefer.

[ahaas, 2016-07-13 12:51:16]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 12:51:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-07-13 12:51:54]

https://codereview.chromium.org/2150523002/diff/1/src/codegen.cc
File src/codegen.cc (right):

https://codereview.chromium.org/2150523002/diff/1/src/codegen.cc#newcode124
src/codegen.cc:124: bool is_self_ref_available) {
On 2016/07/13 at 12:42:44, Michael Starzinger wrote:
> nit: We could pass in the "Handle<Object> self_reference" explicitly. WDYT?

Done.

[Michael Starzinger, 2016-07-13 12:56:22]

LGTM from my end.

[Benedikt Meurer (Google), 2016-07-13 13:05:32]

On 2016/07/13 12:56:22, Michael Starzinger wrote:
> LGTM from my end.

LGTM

[commit-bot: I haz the power, 2016-07-13 13:14:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 13:14:16]

Dry run: This issue passed the CQ dry run.

[ahaas, 2016-07-13 13:14:37]

The CQ bit was checked by ahaas@chromium.org

[commit-bot: I haz the power, 2016-07-13 13:14:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 13:18:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 13:18:16]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/19348)

[Jarin, 2016-07-13 13:49:16]

jarin@chromium.org changed reviewers:
+ jarin@chromium.org

[Jarin, 2016-07-13 13:49:16]

lgtm

[ahaas, 2016-07-13 13:49:32]

The CQ bit was checked by ahaas@chromium.org

[commit-bot: I haz the power, 2016-07-13 13:49:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 13:52:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-13 13:52:04]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 13:54:46]

Description was changed from

==========
[turbofan] Do not use the self reference for turbofan functions.

The self reference requires the allocation of a handle in the macro
assembler, which is not possible if we instantiate the macro assembler
in a worker thread.

R=mstarzinger@chromium.org, bmeurer@chromium.org
==========

to

==========
[turbofan] Do not use the self reference for turbofan functions.

The self reference requires the allocation of a handle in the macro
assembler, which is not possible if we instantiate the macro assembler
in a worker thread.

R=mstarzinger@chromium.org, bmeurer@chromium.org

Committed: https://crrev.com/49ef529b3af50f5daadacdcdcd6be3a307c10af5
Cr-Commit-Position: refs/heads/master@{#37713}
==========

[commit-bot: I haz the power, 2016-07-13 13:54:47]

Patchset 2 (id:??) landed as
https://crrev.com/49ef529b3af50f5daadacdcdcd6be3a307c10af5
Cr-Commit-Position: refs/heads/master@{#37713}

[Michael Hablich, 2016-07-13 14:18:54]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2147943002/ by hablich@chromium.org.

The reason for reverting is: Dependency of the roll unblocking revert
https://codereview.chromium.org/2147883003/.

[ahaas, 2016-07-13 14:26:31]

ahaas@chromium.org changed reviewers:
+ bmeurer@google.com