Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2151443002: Remove incorrect DCHECKS from RTC*RequestPromiseImpl (Closed)

Created:
4 years, 5 months ago by Guido Urdaneta
Modified:
4 years, 5 months ago
Reviewers:
hbos_chromium
CC:
chromium-reviews, blink-reviews, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove incorrect DCHECKS from RTC*RequestPromiseImpl These DCHECKS sometimes cause crashes in tests. A request may be destroyed before receiving a reply (e.g., if the document is reloaded in the middle of a reply) BUG=626893 Committed: https://crrev.com/eb281fc3c0ad655e0a9b4381e70b3cefa535935d Cr-Commit-Position: refs/heads/master@{#405144}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionRequestPromiseImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCVoidRequestPromiseImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Guido Urdaneta
4 years, 5 months ago (2016-07-13 13:02:26 UTC) #3
hbos_chromium
lgtm
4 years, 5 months ago (2016-07-13 13:05:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151443002/1
4 years, 5 months ago (2016-07-13 13:05:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 14:33:22 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 14:37:10 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb281fc3c0ad655e0a9b4381e70b3cefa535935d
Cr-Commit-Position: refs/heads/master@{#405144}

Powered by Google App Engine
This is Rietveld 408576698