Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Side by Side Diff: third_party/WebKit/Source/modules/peerconnection/RTCVoidRequestPromiseImpl.cpp

Issue 2151443002: Remove incorrect DCHECKS from RTC*RequestPromiseImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionRequestPromiseImpl.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/peerconnection/RTCVoidRequestPromiseImpl.h" 5 #include "modules/peerconnection/RTCVoidRequestPromiseImpl.h"
6 6
7 #include "bindings/core/v8/ScriptPromiseResolver.h" 7 #include "bindings/core/v8/ScriptPromiseResolver.h"
8 #include "core/dom/DOMException.h" 8 #include "core/dom/DOMException.h"
9 #include "core/dom/ExceptionCode.h" 9 #include "core/dom/ExceptionCode.h"
10 #include "modules/peerconnection/RTCPeerConnection.h" 10 #include "modules/peerconnection/RTCPeerConnection.h"
11 11
12 namespace blink { 12 namespace blink {
13 13
14 RTCVoidRequestPromiseImpl* RTCVoidRequestPromiseImpl::create(RTCPeerConnection* requester, ScriptPromiseResolver* resolver) 14 RTCVoidRequestPromiseImpl* RTCVoidRequestPromiseImpl::create(RTCPeerConnection* requester, ScriptPromiseResolver* resolver)
15 { 15 {
16 return new RTCVoidRequestPromiseImpl(requester, resolver); 16 return new RTCVoidRequestPromiseImpl(requester, resolver);
17 } 17 }
18 18
19 RTCVoidRequestPromiseImpl::RTCVoidRequestPromiseImpl(RTCPeerConnection* requeste r, ScriptPromiseResolver* resolver) 19 RTCVoidRequestPromiseImpl::RTCVoidRequestPromiseImpl(RTCPeerConnection* requeste r, ScriptPromiseResolver* resolver)
20 : m_requester(requester) 20 : m_requester(requester)
21 , m_resolver(resolver) 21 , m_resolver(resolver)
22 { 22 {
23 DCHECK(m_requester); 23 DCHECK(m_requester);
24 DCHECK(m_resolver); 24 DCHECK(m_resolver);
25 } 25 }
26 26
27 RTCVoidRequestPromiseImpl::~RTCVoidRequestPromiseImpl() 27 RTCVoidRequestPromiseImpl::~RTCVoidRequestPromiseImpl()
28 { 28 {
29 DCHECK(!m_requester);
30 } 29 }
31 30
32 void RTCVoidRequestPromiseImpl::requestSucceeded() 31 void RTCVoidRequestPromiseImpl::requestSucceeded()
33 { 32 {
34 if (m_requester && m_requester->shouldFireDefaultCallbacks()) { 33 if (m_requester && m_requester->shouldFireDefaultCallbacks()) {
35 m_resolver->resolve(); 34 m_resolver->resolve();
36 } else { 35 } else {
37 // This is needed to have the resolver release its internal resources 36 // This is needed to have the resolver release its internal resources
38 // while leaving the associated promise pending as specified. 37 // while leaving the associated promise pending as specified.
39 m_resolver->detach(); 38 m_resolver->detach();
(...skipping 22 matching lines...) Expand all
62 } 61 }
63 62
64 DEFINE_TRACE(RTCVoidRequestPromiseImpl) 63 DEFINE_TRACE(RTCVoidRequestPromiseImpl)
65 { 64 {
66 visitor->trace(m_resolver); 65 visitor->trace(m_resolver);
67 visitor->trace(m_requester); 66 visitor->trace(m_requester);
68 RTCVoidRequest::trace(visitor); 67 RTCVoidRequest::trace(visitor);
69 } 68 }
70 69
71 } // namespace blink 70 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionRequestPromiseImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698