chrome/browser/resources/settings/site_settings/site_data_details_dialog.html - Issue 2151383002: MD Settings: Use <button class="dropdown-item"> for drop-down options.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings/site_data_details_dialog.html

Issue 2151383002: MD Settings: Use <button class="dropdown-item"> for drop-down options. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/site_settings/media_picker.html ('k') | chrome/browser/resources/settings/site_settings/site_details_permission.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/site_settings/site_data_details_dialog.html

diff --git a/chrome/browser/resources/settings/site_settings/site_data_details_dialog.html b/chrome/browser/resources/settings/site_settings/site_data_details_dialog.html

index a854e249555a99bb375ed55194fbddb760556f84..f4f81cdbbd841d3b6731dafa0f76f07175901d44 100644

--- a/chrome/browser/resources/settings/site_settings/site_data_details_dialog.html

+++ b/chrome/browser/resources/settings/site_settings/site_data_details_dialog.html

@@ -1,6 +1,5 @@

-<link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.html">

@@ -24,9 +23,10 @@

attr-for-selected="picker-value"

on-iron-activate="onItemSelected_">

- <paper-item picker-value$="[[item.id]]">

+ <button class="dropdown-item" role="option"

+ picker-value$="[[item.id]]">

[[item.title]]

- </paper-item>

+ </button>

</template>

</paper-listbox>

</paper-dropdown-menu>