Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2151373002: Share LibrarySpecificUnits when possible (Closed)

Created:
4 years, 5 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Share LibrarySpecificUnits when possible

Patch Set 1 #

Patch Set 2 : Clean-up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -12 lines) Patch
M pkg/analyzer/lib/src/context/cache.dart View 3 chunks +10 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 3 chunks +25 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 1 2 chunks +11 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart_work_manager.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/driver.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/html_work_manager.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/options_work_manager.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 5 chunks +15 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/context/cache_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 1 chunk +98 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_work_manager_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/driver_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/html_work_manager_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/options_work_manager_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Brian Wilkerson
4 years, 5 months ago (2016-07-15 21:19:08 UTC) #2
With this change we hold onto a little more than half the LSU's we were
retaining before. Similar changes to come.

Powered by Google App Engine
This is Rietveld 408576698