pkg/analyzer/lib/src/task/dart.dart - Issue 2151373002: Share LibrarySpecificUnits when possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/task/dart.dart

Issue 2151373002: Share LibrarySpecificUnits when possible (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Clean-up Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/task/dart.dart

diff --git a/pkg/analyzer/lib/src/task/dart.dart b/pkg/analyzer/lib/src/task/dart.dart

index 4dde93d09a6e0d4e3cd3ad6d340bf7f17321b50b..3929afd2caedff50d98424994ee98de59133be13 100644

--- a/pkg/analyzer/lib/src/task/dart.dart

+++ b/pkg/analyzer/lib/src/task/dart.dart

@@ -4082,8 +4082,10 @@ class ParseDartTask extends SourceBasedAnalysisTask {

..addAll(exportedSources)

..addAll(unitSources))

.toList();

- List<LibrarySpecificUnit> librarySpecificUnits =

- unitSources.map((s) => new LibrarySpecificUnit(source, s)).toList();

+ List<LibrarySpecificUnit> librarySpecificUnits = unitSources

+ .map((s) => (context as InternalAnalysisContext)

+ .getLibrarySpecificUnit(source, s))

+ .toList();

outputs[EXPLICITLY_IMPORTED_LIBRARIES] = explicitlyImportedSources;

outputs[EXPORTED_LIBRARIES] = exportedSources;

outputs[IMPORTED_LIBRARIES] = importedSources;