Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 2151353002: [InputEvent] Replace |EditAction| with |InputType| (Closed)

Created:
4 years, 5 months ago by chongz
Modified:
4 years, 5 months ago
Reviewers:
bokan, esprehn, yosin_UTC9
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@inputevent-text-styling
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[InputEvent] Replace |EditAction| with |InputType| |EditAction| is used to describe editing operations in Blink internal only, however with the introduction of |InputEvent| we got a new type |InputType| which does the same thing and SPECed. Since having both is redundant, this CL removes |EditAction| and finalized the list of possible |InputType|. This CL shouldn't have too much web-exposed effect (except some trivial command mapping). BUG=627740 Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/InputEvent/blink-dev/RrnitB0OElc/rirueVekCwAJ Committed: https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992 Cr-Commit-Position: refs/heads/master@{#407073}

Patch Set 1 : Replaced |EditAction| with |InputType| #

Unified diffs Side-by-side diffs Delta from patch set Stats (+372 lines, -301 lines) Patch
M third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-execcommand.html View 3 chunks +33 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-keyboard.html View 3 chunks +13 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.h View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 9 chunks +16 lines, -55 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.h View 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 5 chunks +28 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/core/editing/commands/EditAction.h View 1 chunk +0 lines, -74 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditCommand.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 17 chunks +102 lines, -69 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertListCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/MoveSelectionCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/MoveSelectionCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/RemoveFormatCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/RemoveFormatCommand.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.h View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp View 1 chunk +17 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/UndoStep.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/UnlinkCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/UnlinkCommand.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/InputEvent.h View 2 chunks +38 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/events/InputEvent.cpp View 1 chunk +34 lines, -3 lines 0 comments Download

Messages

Total messages: 45 (34 generated)
chongz
yosin@ PTAL, thanks!
4 years, 5 months ago (2016-07-18 20:43:51 UTC) #29
yosin_UTC9
lgtm Thanks for prompt work!
4 years, 5 months ago (2016-07-19 01:23:57 UTC) #30
chongz
esprehn@ Can you take a look at "InputEvent.h/cpp" please? Thanks!
4 years, 5 months ago (2016-07-19 14:24:23 UTC) #32
esprehn
On 2016/07/19 at 14:24:23, chongz wrote: > esprehn@ Can you take a look at "InputEvent.h/cpp" ...
4 years, 5 months ago (2016-07-20 16:37:16 UTC) #33
chongz
On 2016/07/20 16:37:16, esprehn wrote: > On 2016/07/19 at 14:24:23, chongz wrote: > > esprehn@ ...
4 years, 5 months ago (2016-07-20 16:46:30 UTC) #35
chongz
esprehn@ here is the intent to implement for InputEvent, currently it's behind a flag, PTAL, ...
4 years, 5 months ago (2016-07-20 20:54:04 UTC) #36
chongz
bokan@ can you take a look at "InputEvent.h/cpp" please? Thanks! (esprehn@ seems not available.)
4 years, 5 months ago (2016-07-21 19:24:34 UTC) #38
bokan
rs lgtm
4 years, 5 months ago (2016-07-22 02:05:18 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151353002/100001
4 years, 5 months ago (2016-07-22 03:14:42 UTC) #41
commit-bot: I haz the power
Committed patchset #1 (id:100001)
4 years, 5 months ago (2016-07-22 05:33:21 UTC) #43
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 05:36:23 UTC) #45
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992
Cr-Commit-Position: refs/heads/master@{#407073}

Powered by Google App Engine
This is Rietveld 408576698