Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1512)

Unified Diff: third_party/WebKit/Source/core/editing/commands/TypingCommand.h

Issue 2151353002: [InputEvent] Replace |EditAction| with |InputType| (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@inputevent-text-styling
Patch Set: Replaced |EditAction| with |InputType| Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/TypingCommand.h
diff --git a/third_party/WebKit/Source/core/editing/commands/TypingCommand.h b/third_party/WebKit/Source/core/editing/commands/TypingCommand.h
index 30d3554fbf83358aba07c30dc054344b6683f2ae..25fe0192616a1d2a25de8faa10621c107b667bc3 100644
--- a/third_party/WebKit/Source/core/editing/commands/TypingCommand.h
+++ b/third_party/WebKit/Source/core/editing/commands/TypingCommand.h
@@ -77,7 +77,6 @@ public:
void deleteSelection(bool smartDelete, EditingState*);
void setCompositionType(TextCompositionType type) { m_compositionType = type; }
- ETypingCommand commandTypeOfOpenCommand() const { return m_commandType; }
TextCompositionType compositionType() const { return m_compositionType; }
// |TypingCommand| may contain multiple |InsertTextCommand|, should return |textDataForInputEvent()| of the last one.
String textDataForInputEvent() const final;
@@ -102,7 +101,7 @@ private:
static TypingCommand* lastTypingCommandIfStillOpenForTyping(LocalFrame*);
void doApply(EditingState*) override;
- EditAction editingAction() const override;
+ InputEvent::InputType inputType() const override;
bool isTypingCommand() const override;
bool preservesTypingStyle() const override { return m_preservesTypingStyle; }
void setShouldRetainAutocorrectionIndicator(bool retain) override { m_shouldRetainAutocorrectionIndicator = retain; }
@@ -117,6 +116,7 @@ private:
bool makeEditableRootEmpty(EditingState*);
void updateCommandTypeOfOpenCommand(ETypingCommand typingCommand) { m_commandType = typingCommand; }
+ ETypingCommand commandTypeOfOpenCommand() const { return m_commandType; }
ETypingCommand m_commandType;
String m_textToInsert;

Powered by Google App Engine
This is Rietveld 408576698