Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/js_protocol.json

Issue 2151273003: [DevTools] Move browser logging from Console domain to Log domain. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@internals-method
Patch Set: protocol, cleanup Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/js_protocol.json
diff --git a/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json b/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json
index 93899a46f159cc95af4bb2ac72d5760abe15304c..db84bdb4fe33983d65ce137679a6d1381af4f968 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json
+++ b/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json
@@ -254,6 +254,10 @@
"description": "Disables reporting of execution contexts creation."
},
{
+ "name": "clearMessages",
pfeldman 2016/07/16 01:56:10 discardConsoleEntries
dgozman 2016/07/18 19:18:53 Done.
+ "description": "Clears collected exceptions and console API calls."
pfeldman 2016/07/16 01:56:10 hidden
dgozman 2016/07/18 19:18:53 Done.
+ },
+ {
"name": "setCustomObjectFormatterEnabled",
"parameters": [
{
@@ -721,8 +725,9 @@
},
{
"domain": "Console",
- "description": "Console domain defines methods and events for interaction with the JavaScript console. Console collects messages created by means of the <a href='http://getfirebug.com/wiki/index.php/Console_API'>JavaScript Console API</a>. One needs to enable this domain using <code>enable</code> command in order to start receiving the console messages. Browser collects messages issued while console domain is not enabled as well and reports them using <code>messageAdded</code> notification upon enabling.",
+ "description": "This domain is deprecated - use Runtime or Log instead.",
"dependencies": ["Runtime"],
+ "deprecated": true,
"types": [
{
"id": "ConsoleMessage",
@@ -733,17 +738,14 @@
{ "name": "level", "type": "string", "enum": ["log", "warning", "error", "debug", "info"], "description": "Message severity." },
{ "name": "text", "type": "string", "description": "Message text." },
{ "name": "type", "type": "string", "optional": true, "enum": ["log", "dir", "dirxml", "table", "trace", "clear", "startGroup", "startGroupCollapsed", "endGroup", "assert", "profile", "profileEnd"], "description": "Never present. Use Runtime.consoleAPICalled instead." },
- { "name": "scriptId", "type": "string", "optional": true, "description": "Script ID of the message origin." },
+ { "name": "scriptId", "type": "string", "optional": true, "description": "Never present." },
pfeldman 2016/07/16 01:56:09 nuke, it was optional, so you are free to not pass
dgozman 2016/07/18 19:18:52 Done.
{ "name": "url", "type": "string", "optional": true, "description": "URL of the message origin." },
- { "name": "line", "type": "integer", "optional": true, "description": "Line number in the resource that generated this message." },
- { "name": "column", "type": "integer", "optional": true, "description": "Column number in the resource that generated this message." },
- { "name": "repeatCount", "type": "integer", "optional": true, "description": "Repeat count for repeated messages." },
+ { "name": "line", "type": "integer", "optional": true, "description": "Line number in the resource that generated this message (1-based)." },
+ { "name": "column", "type": "integer", "optional": true, "description": "Column number in the resource that generated this message (1-based)." },
+ { "name": "repeatCount", "type": "integer", "optional": true, "description": "Never present." },
{ "name": "parameters", "type": "array", "items": { "$ref": "Runtime.RemoteObject" }, "optional": true, "description": "Never present. Use Runtime.consoleAPICalled instead." },
- { "name": "stack", "$ref": "Runtime.StackTrace", "optional": true, "description": "JavaScript stack trace for assertions and error messages." },
- { "name": "networkRequestId", "type": "string", "optional": true, "description": "Identifier of the network request associated with this message." },
- { "name": "timestamp", "$ref": "Runtime.Timestamp", "description": "Timestamp, when this message was fired.", "hidden": true },
- { "name": "executionContextId", "$ref": "Runtime.ExecutionContextId", "optional": true, "description": "Identifier of the context where this message was created", "hidden": true },
- { "name": "workerId", "type": "string", "optional": true, "description": "Identifier of the worker this message came from.", "hidden": true }
+ { "name": "stack", "$ref": "Runtime.StackTrace", "optional": true, "description": "Never present." },
pfeldman 2016/07/16 01:56:10 nuke, it was optional, so you are free to not pass
dgozman 2016/07/18 19:18:52 Done.
+ { "name": "networkRequestId", "type": "string", "optional": true, "description": "Never present. Use Log domain instead." }
pfeldman 2016/07/16 01:56:10 nuke, it was optional, so you are free to not pass
dgozman 2016/07/18 19:18:53 Done.
]
}
],
@@ -758,7 +760,7 @@
},
{
"name": "clearMessages",
- "description": "Clears console messages collected in the browser."
+ "description": "Does nothing."
}
],
"events": [
@@ -775,7 +777,7 @@
{ "name": "count", "type": "integer", "description": "New repeat count value." },
{ "name": "timestamp", "$ref": "Runtime.Timestamp", "description": "Timestamp of most recent message in batch.", "hidden": true }
],
- "description": "Is not issued. Will be gone in the future versions of the protocol.",
+ "description": "Not issued.",
"deprecated": true
},
{

Powered by Google App Engine
This is Rietveld 408576698