Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Unified Diff: third_party/WebKit/Source/core/inspector/browser_protocol.json

Issue 2151273003: [DevTools] Move browser logging from Console domain to Log domain. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@internals-method
Patch Set: protocol, cleanup Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/browser_protocol.json
diff --git a/third_party/WebKit/Source/core/inspector/browser_protocol.json b/third_party/WebKit/Source/core/inspector/browser_protocol.json
index f4a2de95d5902101f8e438b48af95ec9cb40b42d..ee336d060a22ea65677f95e74650f1bae4b4563f 100644
--- a/third_party/WebKit/Source/core/inspector/browser_protocol.json
+++ b/third_party/WebKit/Source/core/inspector/browser_protocol.json
@@ -4183,6 +4183,63 @@
]
},
{
+ "domain": "Log",
+ "description": "Provides access to log messages.",
+ "dependencies": ["Runtime", "Network", "Worker"],
+ "hidden": true,
+ "types": [
+ {
+ "id": "Location",
pfeldman 2016/07/16 01:56:09 inline?
dgozman 2016/07/18 19:18:52 Done.
+ "type": "object",
+ "description": "Location in the source. TODO(dgozman): move to Runtime.",
+ "properties": [
+ { "name": "url", "type": "string", "optional": true, "description": "URL of the resource if known." },
+ { "name": "scriptId", "$ref": "Runtime.ScriptId", "optional": true, "description": "Id of script resource when available." },
pfeldman 2016/07/16 01:56:09 Do we need this?
dgozman 2016/07/18 19:18:52 Removed.
+ { "name": "lineNumber", "type": "integer", "optional": true, "description": "Line number in the resource." },
+ { "name": "columnNumber", "type": "integer", "optional": true, "description": "Column number in the resource." },
pfeldman 2016/07/16 01:56:09 I don't think we pass it outside stack.
dgozman 2016/07/18 19:18:52 Done.
+ { "name": "stackTrace", "$ref": "Runtime.StackTrace", "optional": true, "description": "JavaScript stack trace." }
+ ]
+ },
+ {
+ "id": "LogMessage",
+ "type": "object",
+ "description": "Log message.",
+ "properties": [
+ { "name": "source", "type": "string", "enum": ["xml", "javascript", "network", "storage", "appcache", "rendering", "security", "deprecation", "worker", "other"], "description": "Message source." },
+ { "name": "level", "type": "string", "enum": ["log", "warning", "error", "debug", "info"], "description": "Message severity." },
+ { "name": "text", "type": "string", "description": "Message text." },
+ { "name": "timestamp", "$ref": "Runtime.Timestamp", "description": "Timestamp when this message was logged." },
+ { "name": "location", "$ref": "Location", "description": "Location where this message was logged." },
+ { "name": "networkRequestId", "$ref": "Network.RequestId", "optional": true, "description": "Identifier of the network request associated with this message." },
+ { "name": "workerId", "type": "string", "optional": true, "description": "Identifier of the worker this message came from." }
+ ]
+ }
+ ],
+ "commands": [
+ {
+ "name": "enable",
+ "description": "Enables log domain, sends the messages collected so far to the client by means of the <code>messageLogged</code> notification."
+ },
+ {
+ "name": "disable",
+ "description": "Disables log domain, prevents further log messages from being reported to the client."
+ },
+ {
+ "name": "clear",
+ "description": "Clears the log."
+ }
+ ],
+ "events": [
+ {
+ "name": "messageLogged",
+ "parameters": [
+ { "name": "message", "$ref": "LogMessage", "description": "The message." }
+ ],
+ "description": "Issued when new message was logged."
+ }
+ ]
+ },
+ {
"domain": "Browser",
"description": "The Browser domain allows listing, creating, activating and attaching to the targets.",
"hidden": true,

Powered by Google App Engine
This is Rietveld 408576698