Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 2151143002: Make default constructor of Font class to initialize all member variables (Closed)

Created:
4 years, 5 months ago by yosin_UTC9
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Make default constructor of Font class to initialize all member variables This patch makes default constructor of |Font| class to initialize |m_canShapeWordByWord| and |m_shapeWordByWordComputed| member variables to make MSAN happy. This patch is a preparation of re-landing http://crrev.com/2082893005, which is revered by uninitialized member variables of |Font|. BUG=618237, 622566 TEST=n/a; MSAN will check this Review-Url: https://codereview.chromium.org/2091633002 Cr-Commit-Position: refs/heads/master@{#401567} (cherry picked from commit 2217e8c563575ead5c9450408529340ec93ccef7)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/fonts/Font.cpp View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
yosin_UTC9
4 years, 5 months ago (2016-07-15 01:21:30 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) to pending queue manually as
f7ee9a7503d2abd2317bcbe835d377fed8480c92.

Powered by Google App Engine
This is Rietveld 408576698