Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 2091633002: Make default constructor of Font class to initialize all member variables (Closed)

Created:
3 years ago by yosin_UTC9
Modified:
3 years ago
Reviewers:
drott, eae
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make default constructor of Font class to initialize all member variables This patch makes default constructor of |Font| class to initialize |m_canShapeWordByWord| and |m_shapeWordByWordComputed| member variables to make MSAN happy. This patch is a preparation of re-landing http://crrev.com/2082893005, which is revered by uninitialized member variables of |Font|. BUG=618237, 622566 TEST=n/a; MSAN will check this Committed: https://crrev.com/2217e8c563575ead5c9450408529340ec93ccef7 Cr-Commit-Position: refs/heads/master@{#401567}

Patch Set 1 : 2016-06-23T10:42:43 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/fonts/Font.cpp View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
yosin_UTC9
PTAL
3 years ago (2016-06-23 03:33:53 UTC) #6
eae
LGTM
3 years ago (2016-06-23 07:45:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2091633002/1
3 years ago (2016-06-23 07:46:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years ago (2016-06-23 09:41:20 UTC) #11
commit-bot: I haz the power
3 years ago (2016-06-23 09:42:37 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2217e8c563575ead5c9450408529340ec93ccef7
Cr-Commit-Position: refs/heads/master@{#401567}

Powered by Google App Engine
This is Rietveld 408576698