Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2151043002: roll libyuv from r1579 to r1608 (Closed)

Created:
4 years, 5 months ago by fbarchard1
Modified:
4 years, 5 months ago
Reviewers:
Robert Sesek, wjmaclean
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

roll libyuv from r1579 to r1608 roll libyuv for GN fix to chromium internal settings, enabling more warnings and consistant with gyp build options. Add ARGBExtractAlpha function. Fix YUV bilinear filter improved filter accuracy; uses 128-f instead of 127-f. unittest fixes for Arm scaler - use J420 for J422 pointing to same row, improving performance and accuracy. Fix ios jpeg build error. Fix BlendPlaneRow_SSSE3 impossible constraints on android full debug Fix unittests to avoid private row.h header. Fix vector_size(32) build error on yuv conversion for intel on gcc 4.4. BUG=chromium:626065, libyuv:572, libyuv:575, libyuv:579, libyuv:573, libyuv:583, chromium:601140, libyuv:582, libyuv:581, chromium:601140, libyuv:578, libyuv:581, libyuv:580, libyuv:586, libyuv:590, webrtc:5006, libyuv:593, libyuv:592, libyuv:594, libyuv:595, libyuv:597, libyuv:599, libyuv:598, libyuv:600, libyuv:602, libyuv:605, libyuv:610, libyuv:612, libyuv:618, libyuv:620, webrtc:6091, webrtc:6094, libyuv:616, libyuv:623, libyuv:624, libyuv:625 TEST=try bots pass Committed: https://crrev.com/38d96aa1885a7886f96d5b6f8da28f58944c23cc Cr-Commit-Position: refs/heads/master@{#405565}

Patch Set 1 #

Patch Set 2 : Merge branch 'master' of https://chromium.googlesource.com/chromium/src into libyuv_r1608 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
fbarchard1
Removed duplicate LIBYUV_DISABLE_X86 in BUILD.gn in favor of headers which contain an ifdef: // MemorySanitizer ...
4 years, 5 months ago (2016-07-14 19:24:54 UTC) #4
fbarchard1
In this CL https://codereview.chromium.org/2149823003 The following was removed from BUILD.gn 90 if (is_msan) { 91 ...
4 years, 5 months ago (2016-07-14 19:37:25 UTC) #9
wjmaclean
On 2016/07/14 19:24:54, fbarchard1 wrote: > Removed duplicate LIBYUV_DISABLE_X86 in BUILD.gn in favor of headers ...
4 years, 5 months ago (2016-07-14 19:41:02 UTC) #10
Robert Sesek
lgtm
4 years, 5 months ago (2016-07-14 20:35:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151043002/20001
4 years, 5 months ago (2016-07-14 20:48:01 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-14 20:55:18 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 20:57:53 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/38d96aa1885a7886f96d5b6f8da28f58944c23cc
Cr-Commit-Position: refs/heads/master@{#405565}

Powered by Google App Engine
This is Rietveld 408576698