Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 2149823003: Remove DISABLE_X86 from build.gn (Closed)

Created:
4 years, 5 months ago by fbarchard1
Modified:
4 years, 5 months ago
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Remove DISABLE_X86 from build.gn Fix for duplicate define ../../third_party/libyuv/include/libyuv/scale_row.h:29:9: error: 'LIBYUV_DISABLE_X86' macro redefined [-Werror,-Wmacro-redefined] ^ GYP version relys on headers disabling the optimization. This CL does the same for BUILD.gn TBR=kjellander@chromium.org BUG=libyuv:625 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/e74086bfe3165ddc8616c3ceb5d2dc50c4db1d82

Patch Set 1 #

Patch Set 2 : remove DISABLE_X86 from build.gn #

Patch Set 3 : remove DISABLE_X86 from build.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
M README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/version.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
fbarchard1
4 years, 5 months ago (2016-07-14 18:59:11 UTC) #1
fbarchard1
Committed patchset #3 (id:40001) manually as e74086bfe3165ddc8616c3ceb5d2dc50c4db1d82 (presubmit successful).
4 years, 5 months ago (2016-07-14 19:14:26 UTC) #6
kjellander_chromium
4 years, 5 months ago (2016-07-24 09:41:22 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698