Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2150973002: Remove threading primitives from ParseHTMLOnMainThread (Closed)

Created:
4 years, 5 months ago by Charlie Harrison
Modified:
4 years, 5 months ago
Reviewers:
kinuko, kouhei (in TOK)
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Remove threading primitives from ParseHTMLOnMainThread This patch removes locks from ParsedChunkQueue, and use of crossThreadBind in HTMLDocumentParser/BackgroundHTMLParser, which introduces unecessary copies if we're not actually crossing threads. BUG=627198 Review-Url: https://codereview.chromium.org/2134323002 Cr-Commit-Position: refs/heads/master@{#405139} (cherry picked from commit 0b4376118260f28c64433db1002e23ed8c663cb0) Add an experiment group via Settings to tokenize synchronously This patch adds an experiment group that tokenizes synchronously on the main thread in response to a recieve data IPC. If this regresses performance, we can augment the CL slightly to only synchronously tokenize when the main parser has no work. BUG=627161 Review-Url: https://codereview.chromium.org/2139703003 Cr-Commit-Position: refs/heads/master@{#405035} (cherry picked from commit 2fcf4bab78301b1c7b64b1b47547e7e5a70da65f) NOPRESUBMIT=true TBR=kouhei@chromium.org,kinuko@chromium.org NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -33 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Settings.in View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp View 3 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.h View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 11 chunks +17 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/ParsedChunkQueue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/ParsedChunkQueue.cpp View 5 chunks +31 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150973002/1
4 years, 5 months ago (2016-07-14 17:38:18 UTC) #2
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-14 17:38:19 UTC) #3
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 5 months ago (2016-07-14 17:38:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150973002/1
4 years, 5 months ago (2016-07-14 17:40:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 17:42:25 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 17:42:31 UTC) #12
Message was sent while issue was closed.
CQ bit was unchecked.

Powered by Google App Engine
This is Rietveld 408576698