|
|
Chromium Code Reviews|
Created:
4 years, 5 months ago by Charlie Harrison Modified:
4 years, 5 months ago CC:
chromium-reviews, blink-reviews-html_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, dglazkov+blink, darin-cc_chromium.org, blink-reviews, kinuko+watch Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd an experiment group via Settings to tokenize synchronously
This patch adds an experiment group that tokenizes synchronously
on the main thread in response to a recieve data IPC.
If this regresses performance, we can augment the CL slightly
to only synchronously tokenize when the main parser has no
work.
BUG=627161
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Committed: https://crrev.com/2fcf4bab78301b1c7b64b1b47547e7e5a70da65f
Cr-Commit-Position: refs/heads/master@{#405035}
Patch Set 1 #Patch Set 2 : rebaseline on master #
Messages
Total messages: 27 (14 generated)
Description was changed from ========== Add an experiment group via Settings to tokenize synchronously Clean up TODOs in TestNavigationManager BUG= ========== to ========== Add an experiment group via Settings to tokenize synchronously Clean up TODOs in TestNavigationManager BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation ==========
Description was changed from ========== Add an experiment group via Settings to tokenize synchronously Clean up TODOs in TestNavigationManager BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation ========== to ========== Add an experiment group via Settings to tokenize synchronously This patch adds an experiment group that tokenizes synchronously on the main thread in response to a recieve data IPC. BUG=627161 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation ==========
Description was changed from ========== Add an experiment group via Settings to tokenize synchronously This patch adds an experiment group that tokenizes synchronously on the main thread in response to a recieve data IPC. BUG=627161 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation ========== to ========== Add an experiment group via Settings to tokenize synchronously This patch adds an experiment group that tokenizes synchronously on the main thread in response to a recieve data IPC. If this regresses performance, we can augment the CL slightly to only synchronously tokenize when the main parser has no work. BUG=627161 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation ==========
csharrison@chromium.org changed reviewers: + kouhei@chromium.org
PTAL!
kouhei@chromium.org changed reviewers: + kinuko@chromium.org
lgtm +kinuko: Would you take a look at content/
Looks like this can be landed without my stamp, but lgtm anyways
Thanks!
The CQ bit was checked by csharrison@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by csharrison@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by csharrison@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by csharrison@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add an experiment group via Settings to tokenize synchronously This patch adds an experiment group that tokenizes synchronously on the main thread in response to a recieve data IPC. If this regresses performance, we can augment the CL slightly to only synchronously tokenize when the main parser has no work. BUG=627161 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation ========== to ========== Add an experiment group via Settings to tokenize synchronously This patch adds an experiment group that tokenizes synchronously on the main thread in response to a recieve data IPC. If this regresses performance, we can augment the CL slightly to only synchronously tokenize when the main parser has no work. BUG=627161 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add an experiment group via Settings to tokenize synchronously This patch adds an experiment group that tokenizes synchronously on the main thread in response to a recieve data IPC. If this regresses performance, we can augment the CL slightly to only synchronously tokenize when the main parser has no work. BUG=627161 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation ========== to ========== Add an experiment group via Settings to tokenize synchronously This patch adds an experiment group that tokenizes synchronously on the main thread in response to a recieve data IPC. If this regresses performance, we can augment the CL slightly to only synchronously tokenize when the main parser has no work. BUG=627161 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/2fcf4bab78301b1c7b64b1b47547e7e5a70da65f Cr-Commit-Position: refs/heads/master@{#405035} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/2fcf4bab78301b1c7b64b1b47547e7e5a70da65f Cr-Commit-Position: refs/heads/master@{#405035} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
