Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2139703003: Add an experiment group via Settings to tokenize synchronously (Closed)

Created:
4 years, 5 months ago by Charlie Harrison
Modified:
4 years, 5 months ago
Reviewers:
kinuko, kouhei (in TOK)
CC:
chromium-reviews, blink-reviews-html_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, dglazkov+blink, darin-cc_chromium.org, blink-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an experiment group via Settings to tokenize synchronously This patch adds an experiment group that tokenizes synchronously on the main thread in response to a recieve data IPC. If this regresses performance, we can augment the CL slightly to only synchronously tokenize when the main parser has no work. BUG=627161 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/2fcf4bab78301b1c7b64b1b47547e7e5a70da65f Cr-Commit-Position: refs/heads/master@{#405035}

Patch Set 1 #

Patch Set 2 : rebaseline on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Settings.in View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 27 (14 generated)
Charlie Harrison
PTAL!
4 years, 5 months ago (2016-07-11 19:03:00 UTC) #5
kouhei (in TOK)
lgtm +kinuko: Would you take a look at content/
4 years, 5 months ago (2016-07-12 01:38:52 UTC) #7
kinuko
Looks like this can be landed without my stamp, but lgtm anyways
4 years, 5 months ago (2016-07-12 02:37:49 UTC) #8
Charlie Harrison
Thanks!
4 years, 5 months ago (2016-07-12 03:00:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139703003/20001
4 years, 5 months ago (2016-07-12 03:03:32 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/190953)
4 years, 5 months ago (2016-07-12 06:36:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139703003/20001
4 years, 5 months ago (2016-07-12 12:17:38 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191229)
4 years, 5 months ago (2016-07-12 15:40:33 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139703003/20001
4 years, 5 months ago (2016-07-12 19:05:55 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/242838)
4 years, 5 months ago (2016-07-12 21:23:30 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139703003/20001
4 years, 5 months ago (2016-07-13 03:18:45 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 05:03:53 UTC) #25
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 05:06:08 UTC) #27
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2fcf4bab78301b1c7b64b1b47547e7e5a70da65f
Cr-Commit-Position: refs/heads/master@{#405035}

Powered by Google App Engine
This is Rietveld 408576698