Reland add hooks to permission layer for permission action reporting

components/browser_sync/browser/profile_sync_service.h

Index: components/browser_sync/browser/profile_sync_service.h
diff --git a/components/browser_sync/browser/profile_sync_service.h b/components/browser_sync/browser/profile_sync_service.h
index 201e3030e22238cb0df26dffcf1c1b4e5d816482..0e37bcf6215b2a7d9748a6ef977b8b3f046ba7ab 100644
--- a/components/browser_sync/browser/profile_sync_service.h
+++ b/components/browser_sync/browser/profile_sync_service.h
@@ -669,6 +669,7 @@ class ProfileSyncService : public sync_driver::SyncService,
     SYNC_INITIAL_STATE_LIMIT
   };
 
+  friend class PermissionUmaUtilTest;

[pavely, 2016/07/14 19:29:28]

In your code you are using public virtual functions of ProfileSyncService, you
shouldn't open it's private members to the test and rely on internal behavior.
Instead mock ProfileSyncService to make functions return values you want.

[stefanocs, 2016/07/15 01:05:02]

I didn't use mock but I used sync pref to set the preferable data types instead,
is that okay?

   friend class ProfileSyncServicePasswordTest;
   friend class SyncTest;
   friend class TestProfileSyncService;