Reland add hooks to permission layer for permission action reporting

components/browser_sync/browser/profile_sync_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_BROWSER_SYNC_BROWSER_PROFILE_SYNC_SERVICE_H_
 #define COMPONENTS_BROWSER_SYNC_BROWSER_PROFILE_SYNC_SERVICE_H_
 
 #include <memory>
 #include <set>
 #include <string>
@@ skipping 651 matching lines @@
     NOT_SIGNED_IN,            // There is no signed in user.
     NOT_REQUESTED,            // The user turned off sync.
     NOT_REQUESTED_NOT_SETUP,  // The user turned off sync and setup completed
                               // is false. Might indicate a stop-and-clear.
     NEEDS_CONFIRMATION,       // The user must confirm sync settings.
     IS_MANAGED,               // Sync is disallowed by enterprise policy.
     NOT_ALLOWED_BY_PLATFORM,  // Sync is disallowed by the platform.
     SYNC_INITIAL_STATE_LIMIT
   };
 
+  friend class PermissionUmaUtilTest;

[pavely, 2016/07/14 19:29:28]

In your code you are using public virtual functions of ProfileSyncService, you
shouldn't open it's private members to the test and rely on internal behavior.
Instead mock ProfileSyncService to make functions return values you want.

[stefanocs, 2016/07/15 01:05:02]

I didn't use mock but I used sync pref to set the preferable data types instead,
is that okay?

   friend class ProfileSyncServicePasswordTest;
   friend class SyncTest;
   friend class TestProfileSyncService;
   FRIEND_TEST_ALL_PREFIXES(ProfileSyncServiceTest, InitialState);
 
   // Stops the sync engine. Does NOT set IsSyncRequested to false. Use
   // RequestStop for that. |data_fate| controls whether the local sync data is
   // deleted or kept when the engine shuts down.
   void StopImpl(SyncStopDataFate data_fate);
 
@@ skipping 338 matching lines @@
   base::WeakPtrFactory<ProfileSyncService> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileSyncService);
 };
 
 bool ShouldShowActionOnUI(
     const syncer::SyncProtocolError& error);
 
 
 #endif  // COMPONENTS_BROWSER_SYNC_BROWSER_PROFILE_SYNC_SERVICE_H_