Enable PIN configuration settings.

Enable PIN configuration settings.

BUG=603217
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f9eeec1132cd9cf699523c79c36150b9b699eefb
Cr-Commit-Position: refs/heads/master@{#407296}

[jdufault, 2016-07-13 22:21:10]

Description was changed from

==========
Enable PIN configuration settings.

BUG=603217
==========

to

==========
Enable PIN configuration settings.

BUG=603217
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[jdufault, 2016-07-13 22:21:28]

Description was changed from

==========
Enable PIN configuration settings.

BUG=603217
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Enable PIN configuration settings.

BUG=603217
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[jdufault, 2016-07-13 22:21:28]

jdufault@chromium.org changed reviewers:
+ tommycli@chromium.org

[jdufault, 2016-07-13 22:21:54]

Tommy, PTAL. This enables the button that lets users navigate to PIN settings.

[tommycli, 2016-07-13 22:26:25]

https://codereview.chromium.org/2150763002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/people_page.js (right):

https://codereview.chromium.org/2150763002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/people_page.js:70: value: true,
Can we delay this until we have browser tests?

Also - it would be best if we just got the real value instead of changing it
from a false constant to a true constant.

[jdufault, 2016-07-13 22:31:20]

https://codereview.chromium.org/2150763002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/people_page.js (right):

https://codereview.chromium.org/2150763002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/people_page.js:70: value: true,
On 2016/07/13 22:26:25, tommycli wrote:
> Can we delay this until we have browser tests?

PMs/others want to be able to test out the flow ASAP so UX adjustments can be
made.

> Also - it would be best if we just got the real value instead of changing it
> from a false constant to a true constant.

Policy is probably going to take a few weeks to land.

[tommycli, 2016-07-13 22:33:46]

tommycli@chromium.org changed reviewers:
+ dbeam@chromium.org

[tommycli, 2016-07-13 22:33:47]

I'm going to ask dbeam@, the TL for MD Settings. If he's OK with it, so am I.

[jdufault, 2016-07-16 00:23:58]

Description was changed from

==========
Enable PIN configuration settings.

BUG=603217
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Enable PIN configuration settings.

BUG=603217
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation
==========

[jdufault, 2016-07-16 00:24:04]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-16 00:24:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-16 00:24:33]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
   For more details, see http://crbug.com/617627.

[jdufault, 2016-07-16 00:25:45]

I've switched over to using a feature flag, disabled by default. Policy will
probably land post-m54 so right now quick unlock is disabled if the device is
enterprise enrolled.

[jdufault, 2016-07-16 00:26:29]

Also, browser tests are at https://codereview.chromium.org/2157673002/.

[commit-bot: I haz the power, 2016-07-16 00:41:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-16 00:41:37]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[jdufault, 2016-07-18 19:01:42]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 19:03:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 19:03:35]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
   For more details, see http://crbug.com/617627.

[tommycli, 2016-07-18 21:01:28]

I'm supportive of this runtime switch.

https://codereview.chromium.org/2150763002/diff/40001/chromeos/chromeos_switc...
File chromeos/chromeos_switches.h (right):

https://codereview.chromium.org/2150763002/diff/40001/chromeos/chromeos_switc...
chromeos/chromeos_switches.h:77: CHROMEOS_EXPORT extern const char
kEnableQuickUnlockPin[];
I think there are not supposed to be any new --enable-feature flags added to the
command line. Instead, we are using base::FeatureList.

See
https://cs.chromium.org/chromium/src/chrome/common/chrome_features.h?q=chrome...

[commit-bot: I haz the power, 2016-07-18 22:13:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 22:13:08]

Dry run: This issue passed the CQ dry run.

[jdufault, 2016-07-18 23:56:10]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 23:57:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 23:57:02]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-19 01:56:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 01:56:02]

Dry run: This issue passed the CQ dry run.

[jdufault, 2016-07-21 18:42:02]

Ping

[tommycli, 2016-07-21 18:46:05]

https://codereview.chromium.org/2150763002/diff/80001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/chromeos/quick_unlock_handler.cc (right):

https://codereview.chromium.org/2150763002/diff/80001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/chromeos/quick_unlock_handler.cc:16: static
bool EnableQuickUnlockSettings() {
IsQuickUnlockSettingsEnabled?

https://codereview.chromium.org/2150763002/diff/80001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2150763002/diff/80001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:81502: +  <int value="-1276912933"
label="enable-quick-unlock-pin"/>
What's the purpose of these histograms?

[Dan Beam, 2016-07-21 19:07:13]

https://codereview.chromium.org/2150763002/diff/80001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2150763002/diff/80001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:81502: +  <int value="-1276912933"
label="enable-quick-unlock-pin"/>
On 2016/07/21 18:46:05, tommycli wrote:
> What's the purpose of these histograms?

to satisfy a presubmit ;)

[jdufault, 2016-07-21 19:44:26]

I've also added an enrollment check so the PIN keyboard will not be shown on the
lock screen even if the user has enabled it by manually going to
chrome://md-settings/quickUnlock/

https://codereview.chromium.org/2150763002/diff/80001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/chromeos/quick_unlock_handler.cc (right):

https://codereview.chromium.org/2150763002/diff/80001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/chromeos/quick_unlock_handler.cc:16: static
bool EnableQuickUnlockSettings() {
On 2016/07/21 18:46:05, tommycli wrote:
> IsQuickUnlockSettingsEnabled?

Changed to IsQuickUnlockAllowed to mirror quickUnlockAllowed string name.

[jdufault, 2016-07-21 19:44:33]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 19:45:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 19:45:06]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-21 19:47:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 19:47:28]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[tommycli, 2016-07-21 20:02:13]

lgtm

[jdufault, 2016-07-21 23:54:06]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[jdufault, 2016-07-21 23:54:28]

Description was changed from

==========
Enable PIN configuration settings.

BUG=603217
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Enable PIN configuration settings.

BUG=603217
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation
==========

[jdufault, 2016-07-21 23:54:28]

jdufault@chromium.org changed reviewers:
+ achuith@chromium.org, sky@chromium.org

[commit-bot: I haz the power, 2016-07-21 23:54:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 23:54:43]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
   For more details, see http://crbug.com/617627.

[jdufault, 2016-07-21 23:55:53]

sky@, PTAL at c/c/chrome_features*

achuith@, PTAL at c/b/c/l/q/pin_storage*

Thanks!

[commit-bot: I haz the power, 2016-07-21 23:57:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 23:57:04]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[achuithb, 2016-07-22 01:09:38]

On 2016/07/21 23:55:53, jdufault wrote:
> sky@, PTAL at c/c/chrome_features*
> 
> achuith@, PTAL at c/b/c/l/q/pin_storage*
> 
> Thanks!

Looks like you need to rebase

[achuithb, 2016-07-22 01:14:59]

lgtm with nits that I don't feel strongly about

https://codereview.chromium.org/2150763002/diff/140001/chrome/browser/chromeo...
File chrome/browser/chromeos/login/quick_unlock/pin_storage.cc (right):

https://codereview.chromium.org/2150763002/diff/140001/chrome/browser/chromeo...
chrome/browser/chromeos/login/quick_unlock/pin_storage.cc:21: bool
IsDisabledByPolicy() {
Maybe move this to after ComputeSecret? I think kSaltByteSize needs to be at the
top.

Also IsAllowedByPolicy makes the condition below more readable imo.

https://codereview.chromium.org/2150763002/diff/140001/chrome/browser/chromeo...
chrome/browser/chromeos/login/quick_unlock/pin_storage.cc:22: // TODO(jdufault):
Implement a proper policy check. For now, just disable if
file a bug?

https://codereview.chromium.org/2150763002/diff/140001/chrome/browser/chromeo...
chrome/browser/chromeos/login/quick_unlock/pin_storage.cc:117: return
!IsDisabledByPolicy() && IsPinSet() &&
I think booleans like
const bool exceeded_unlock_attempts = unlock_attempt_count() >=
kMaximiumUnlockAttempts;
const bool exceeded_strong_auth_timeout = TimeStringLastStrongAuth() >
kStrongAuthTimeout;

would make this statement more readable.

[Dan Beam, 2016-07-22 01:22:28]

lgtm w/nit

https://codereview.chromium.org/2150763002/diff/140001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/settings/chromeos/quick_unlock_handler.cc (right):

https://codereview.chromium.org/2150763002/diff/140001/chrome/browser/ui/webu...
chrome/browser/ui/webui/settings/chromeos/quick_unlock_handler.cc:34:
html_source->AddBoolean("quickUnlockAllowed", IsQuickUnlockAllowed());
why is it better to have this key ("quickUnlockAllowed") here?  why not just
inline this statement from the calling side?

[achuithb, 2016-07-22 01:55:04]

On 2016/07/22 01:14:59, achuithb wrote:
> lgtm with nits that I don't feel strongly about
> 
>
https://codereview.chromium.org/2150763002/diff/140001/chrome/browser/chromeo...
> File chrome/browser/chromeos/login/quick_unlock/pin_storage.cc (right):
> 
>
https://codereview.chromium.org/2150763002/diff/140001/chrome/browser/chromeo...
> chrome/browser/chromeos/login/quick_unlock/pin_storage.cc:21: bool
> IsDisabledByPolicy() {
> Maybe move this to after ComputeSecret? I think kSaltByteSize needs to be at
the
> top.
> 
> Also IsAllowedByPolicy makes the condition below more readable imo.
> 
>
https://codereview.chromium.org/2150763002/diff/140001/chrome/browser/chromeo...
> chrome/browser/chromeos/login/quick_unlock/pin_storage.cc:22: //
TODO(jdufault):
> Implement a proper policy check. For now, just disable if
> file a bug?
> 
>
https://codereview.chromium.org/2150763002/diff/140001/chrome/browser/chromeo...
> chrome/browser/chromeos/login/quick_unlock/pin_storage.cc:117: return
> !IsDisabledByPolicy() && IsPinSet() &&
> I think booleans like
> const bool exceeded_unlock_attempts = unlock_attempt_count() >=
> kMaximiumUnlockAttempts;
> const bool exceeded_strong_auth_timeout = TimeStringLastStrongAuth() >
> kStrongAuthTimeout;
> 
> would make this statement more readable.

I only looked at this one file

[sky, 2016-07-22 16:38:28]

LGTM

[jdufault, 2016-07-22 19:15:51]

https://codereview.chromium.org/2150763002/diff/140001/chrome/browser/chromeo...
File chrome/browser/chromeos/login/quick_unlock/pin_storage.cc (right):

https://codereview.chromium.org/2150763002/diff/140001/chrome/browser/chromeo...
chrome/browser/chromeos/login/quick_unlock/pin_storage.cc:21: bool
IsDisabledByPolicy() {
On 2016/07/22 01:14:59, achuithb wrote:
> Maybe move this to after ComputeSecret? I think kSaltByteSize needs to be at
the
> top.
> 
> Also IsAllowedByPolicy makes the condition below more readable imo.

Done, moved into another file.

https://codereview.chromium.org/2150763002/diff/140001/chrome/browser/chromeo...
chrome/browser/chromeos/login/quick_unlock/pin_storage.cc:22: // TODO(jdufault):
Implement a proper policy check. For now, just disable if
On 2016/07/22 01:14:59, achuithb wrote:
> file a bug?

Done.

https://codereview.chromium.org/2150763002/diff/140001/chrome/browser/chromeo...
chrome/browser/chromeos/login/quick_unlock/pin_storage.cc:117: return
!IsDisabledByPolicy() && IsPinSet() &&
On 2016/07/22 01:14:59, achuithb wrote:
> I think booleans like
> const bool exceeded_unlock_attempts = unlock_attempt_count() >=
> kMaximiumUnlockAttempts;
> const bool exceeded_strong_auth_timeout = TimeStringLastStrongAuth() >
> kStrongAuthTimeout;
> 
> would make this statement more readable.

Done.

https://codereview.chromium.org/2150763002/diff/140001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/settings/chromeos/quick_unlock_handler.cc (right):

https://codereview.chromium.org/2150763002/diff/140001/chrome/browser/ui/webu...
chrome/browser/ui/webui/settings/chromeos/quick_unlock_handler.cc:34:
html_source->AddBoolean("quickUnlockAllowed", IsQuickUnlockAllowed());
On 2016/07/22 01:22:28, Dan Beam wrote:
> why is it better to have this key ("quickUnlockAllowed") here?  why not just
> inline this statement from the calling side?

I've inlined the html_source->AddBoolean into md_settings_ui.cc and pulled
IsQuickUnlockEnabled into a new file quick_unlock_utils.h/cc that is also used
by PinStorage.

[jdufault, 2016-07-22 19:15:54]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 19:16:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 19:16:49]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
   For more details, see http://crbug.com/617627.

[Dan Beam, 2016-07-22 19:18:57]

lgtm

[jdufault, 2016-07-22 19:19:25]

The CQ bit was unchecked by jdufault@chromium.org

[jdufault, 2016-07-22 19:19:26]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2016-07-22 19:19:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org, achuith@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2150763002/#ps180001
(title: "Nits and small refactor")

[commit-bot: I haz the power, 2016-07-22 19:32:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 19:32:31]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-22 19:40:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 19:40:37]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jdufault, 2016-07-22 19:49:44]

jdufault@chromium.org changed reviewers:
+ isherman@chromium.org

[jdufault, 2016-07-22 19:50:57]

isherman@ PTAL at histograms.xml

[jdufault, 2016-07-22 20:47:24]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 20:48:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 20:48:04]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
   For more details, see http://crbug.com/617627.

[Ilya Sherman, 2016-07-22 21:14:10]

histograms.xml lgtm

[commit-bot: I haz the power, 2016-07-22 21:39:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 21:39:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jdufault, 2016-07-22 22:14:52]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2016-07-22 22:14:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org, achuith@chromium.org, dbeam@chromium.org,
sky@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2150763002/#ps220001
(title: "Fix tests")

[commit-bot: I haz the power, 2016-07-22 22:15:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 22:15:43]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-22 23:27:42]

Description was changed from

==========
Enable PIN configuration settings.

BUG=603217
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Enable PIN configuration settings.

BUG=603217
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-07-22 23:27:44]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2016-07-22 23:29:41]

Description was changed from

==========
Enable PIN configuration settings.

BUG=603217
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Enable PIN configuration settings.

BUG=603217
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f9eeec1132cd9cf699523c79c36150b9b699eefb
Cr-Commit-Position: refs/heads/master@{#407296}
==========

[commit-bot: I haz the power, 2016-07-22 23:29:44]

Patchset 12 (id:??) landed as
https://crrev.com/f9eeec1132cd9cf699523c79c36150b9b699eefb
Cr-Commit-Position: refs/heads/master@{#407296}