Enable PIN configuration settings.

chrome/browser/chromeos/login/quick_unlock/pin_storage.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/quick_unlock/pin_storage.h"
 
 #include "base/base64.h"
 #include "base/strings/string_util.h"
+#include "chrome/browser/browser_process.h"
+#include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"
 #include "chrome/common/pref_names.h"
 #include "chromeos/login/auth/key.h"
 #include "components/pref_registry/pref_registry_syncable.h"
 #include "components/prefs/pref_service.h"
 #include "crypto/random.h"
 
 namespace chromeos {
 
 namespace {
 
+bool IsDisabledByPolicy() {

[achuithb, 2016/07/22 01:14:59]

Maybe move this to after ComputeSecret? I think kSaltByteSize needs to be at the
top.

Also IsAllowedByPolicy makes the condition below more readable imo.

[jdufault, 2016/07/22 19:15:50]

Done, moved into another file.

+  // TODO(jdufault): Implement a proper policy check. For now, just disable if

[achuithb, 2016/07/22 01:14:59]

file a bug?

[jdufault, 2016/07/22 19:15:50]

Done.

+  // the device is enterprise enrolled.
+  return g_browser_process->platform_part()
+      ->browser_policy_connector_chromeos()
+      ->IsEnterpriseManaged();
+}
+
 const int kSaltByteSize = 16;
 
 // Returns a new salt of length |kSaltByteSize|.
 std::string CreateSalt() {
   // The salt needs to be base64 encoded because the pref service requires a
   // UTF8 string.
   std::string salt;
   crypto::RandBytes(base::WriteInto(&salt, kSaltByteSize + 1), kSaltByteSize);
   base::Base64Encode(salt, &salt);
   DCHECK(!salt.empty());
@@ skipping 68 matching lines @@
 
 std::string PinStorage::PinSalt() const {
   return pref_service_->GetString(prefs::kQuickUnlockPinSalt);
 }
 
 std::string PinStorage::PinSecret() const {
   return pref_service_->GetString(prefs::kQuickUnlockPinSecret);
 }
 
 bool PinStorage::IsPinAuthenticationAvailable() const {
-  return IsPinSet() && unlock_attempt_count() < kMaximumUnlockAttempts &&
-         HasStrongAuth() && TimeSinceLastStrongAuth() < kStrongAuthTimeout;
+  return !IsDisabledByPolicy() && IsPinSet() &&

[achuithb, 2016/07/22 01:14:59]

I think booleans like
const bool exceeded_unlock_attempts = unlock_attempt_count() >=
kMaximiumUnlockAttempts;
const bool exceeded_strong_auth_timeout = TimeStringLastStrongAuth() >
kStrongAuthTimeout;

would make this statement more readable.

[jdufault, 2016/07/22 19:15:50]

Done.

+         unlock_attempt_count() < kMaximumUnlockAttempts && HasStrongAuth() &&
+         TimeSinceLastStrongAuth() < kStrongAuthTimeout;
 }
 
 bool PinStorage::TryAuthenticatePin(const std::string& pin) {
   if (!IsPinAuthenticationAvailable())
     return false;
 
   AddUnlockAttempt();
   return ComputeSecret(pin, PinSalt()) == PinSecret();
 }
 
 }  // namespace chromeos