Separate out target defaults in the GN build config.

Separate out target defaults in the GN build config.

This separates out the default values of configs for the various target types into well-named global variables that can be referred to in different places.

This allows us to move the set_defaults calls for various templates to the places where those templates are defined rather than putting them all in BUILDCONFIG. An example of this is the test() target defaults, where the actual template is declared in a .gni file but the defaults have to be global.

Committed: https://crrev.com/edb6ecc9667278999e8b885a4e79849887580d2d
Cr-Commit-Position: refs/heads/master@{#405627}

[brettw, 2016-07-14 20:26:11]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2016-07-14 20:26:12]

This requires the GN roll in https://codereview.chromium.org/2149073003 before
it will work, but is ready for review now.

[brettw, 2016-07-14 21:32:21]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 21:33:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2016-07-14 21:39:39]

Description was changed from

==========
Separate out target defaults in the GN build config.

This separates out the default values of configs for the various target types
into well-named global variables that can be referred to in different places.

This allows us to move the set_defaults calls for various templates to the
places where those templates are defined rather than putting them all in
BUILDCONFIG. An example of this is the testn target defaults, where the actual
template is declared in a .gni file but the defaults have to be global.
==========

to

==========
Separate out target defaults in the GN build config.

This separates out the default values of configs for the various target types
into well-named global variables that can be referred to in different places.

This allows us to move the set_defaults calls for various templates to the
places where those templates are defined rather than putting them all in
BUILDCONFIG. An example of this is the test() target defaults, where the actual
template is declared in a .gni file but the defaults have to be global.
==========

[Dirk Pranke, 2016-07-14 21:40:39]

https://codereview.chromium.org/2150753002/diff/20001/build/config/BUILDCONFI...
File build/config/BUILDCONFIG.gn (right):

https://codereview.chromium.org/2150753002/diff/20001/build/config/BUILDCONFI...
build/config/BUILDCONFIG.gn:459: default_compiler_configs = [
So, these renames aren't strictly needed (or used outside of this file) yet,
right? Is there some path to actually moving them out of this file?

Are you doing the renames just to establish a better convention for default
variables?

[commit-bot: I haz the power, 2016-07-14 22:38:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 22:38:19]

Dry run: This issue passed the CQ dry run.

[brettw, 2016-07-14 23:07:47]

> Are you doing the renames just to establish a better convention for default
> variables?

This patch relies on the names no longer starting with an underscore, meaning
they're now implicitly global rather than being scoped to BUILDCONFIG (since the
point is that other files now use them). As part of this I gave them more
descriptive names since they're now global.

[Dirk Pranke, 2016-07-14 23:29:01]

On 2016/07/14 23:07:47, brettw (ping after 24h) wrote:
> > Are you doing the renames just to establish a better convention for default
> > variables?
> 
> This patch relies on the names no longer starting with an underscore, meaning
> they're now implicitly global rather than being scoped to BUILDCONFIG (since
the
> point is that other files now use them). As part of this I gave them more
> descriptive names since they're now global.

Oh, right, they're being used in split_static_library.gni and test.gni . Never
mind, then.

lgtm.

[brettw, 2016-07-14 23:30:24]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-07-14 23:31:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 23:37:20]

Description was changed from

==========
Separate out target defaults in the GN build config.

This separates out the default values of configs for the various target types
into well-named global variables that can be referred to in different places.

This allows us to move the set_defaults calls for various templates to the
places where those templates are defined rather than putting them all in
BUILDCONFIG. An example of this is the test() target defaults, where the actual
template is declared in a .gni file but the defaults have to be global.
==========

to

==========
Separate out target defaults in the GN build config.

This separates out the default values of configs for the various target types
into well-named global variables that can be referred to in different places.

This allows us to move the set_defaults calls for various templates to the
places where those templates are defined rather than putting them all in
BUILDCONFIG. An example of this is the test() target defaults, where the actual
template is declared in a .gni file but the defaults have to be global.
==========

[commit-bot: I haz the power, 2016-07-14 23:37:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-14 23:38:54]

Description was changed from

==========
Separate out target defaults in the GN build config.

This separates out the default values of configs for the various target types
into well-named global variables that can be referred to in different places.

This allows us to move the set_defaults calls for various templates to the
places where those templates are defined rather than putting them all in
BUILDCONFIG. An example of this is the test() target defaults, where the actual
template is declared in a .gni file but the defaults have to be global.
==========

to

==========
Separate out target defaults in the GN build config.

This separates out the default values of configs for the various target types
into well-named global variables that can be referred to in different places.

This allows us to move the set_defaults calls for various templates to the
places where those templates are defined rather than putting them all in
BUILDCONFIG. An example of this is the test() target defaults, where the actual
template is declared in a .gni file but the defaults have to be global.

Committed: https://crrev.com/edb6ecc9667278999e8b885a4e79849887580d2d
Cr-Commit-Position: refs/heads/master@{#405627}
==========

[commit-bot: I haz the power, 2016-07-14 23:38:55]

Patchset 2 (id:??) landed as
https://crrev.com/edb6ecc9667278999e8b885a4e79849887580d2d
Cr-Commit-Position: refs/heads/master@{#405627}