Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 2149073003: Roll buildtools 031420bbaf..55638fe5c3 (Closed)

Created:
4 years, 5 months ago by brettw
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools 031420bbaf..55638fe5c3 In order to roll GN 547610b292..af92718f55 (r405294:r405547) and pick up the following changes: af92718 GN: Use the correct defaults for templates invoked via target(). af8a964 Allow multiple set_default calls in GN. TBR=dpranke@chromium.org Committed: https://crrev.com/02e666eceee8360308fc93e3c3433a8359b98fc1 Cr-Commit-Position: refs/heads/master@{#405574}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
brettw
4 years, 5 months ago (2016-07-14 19:59:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149073003/1
4 years, 5 months ago (2016-07-14 19:59:27 UTC) #3
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-14 20:01:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 21:22:53 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 21:23:04 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 21:25:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02e666eceee8360308fc93e3c3433a8359b98fc1
Cr-Commit-Position: refs/heads/master@{#405574}

Powered by Google App Engine
This is Rietveld 408576698