Issue 215073003: Move HTMLCollection's id / name cache to a new NamedItemCache class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 215073003: Move HTMLCollection's id / name cache to a new NamedItemCache class (Closed)

Created:
6 years, 9 months ago by Inactive

Modified:
6 years, 8 months ago

Reviewers:
esprehn, eseidel

CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org, adamk

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Move HTMLCollection's id / name cache to a new NamedItemCache class Move HTMLCollection's id / name cache to a new class. HTML's collection m_hasValidIdNameCache, m_idCache and m_nameCache members were replaced by a single OwnPtr that holds an instance of NamedItemCache when populated. Most HTMLCollections do not have a valid namedItemCache so we end up saving some memory. This also makes the code a bit clearer. This patch is based on the following WebKit revision by rniwa@webkit.org: http://trac.webkit.org/changeset/164772 R= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170592

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -49 lines)			Patch
M	Source/core/html/HTMLAllCollection.cpp	View	1 chunk	+8 lines, -7 lines	0 comments	Download
M	Source/core/html/HTMLCollection.h	View	2 chunks	+36 lines, -19 lines	0 comments	Download
M	Source/core/html/HTMLCollection.cpp	View	5 chunks	+9 lines, -17 lines	0 comments	Download
M	Source/core/html/HTMLFormControlsCollection.cpp	View	3 chunks	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/215073003/1

6 years, 8 months ago (2014-04-01 17:53:26 UTC) #4

Message was sent while issue was closed.

Change committed as 170592

Expand Messages | Collapse Messages