Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: Source/core/html/HTMLAllCollection.cpp

Issue 215073003: Move HTMLCollection's id / name cache to a new NamedItemCache class (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/html/HTMLCollection.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2009, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 } 43 }
44 44
45 HTMLAllCollection::~HTMLAllCollection() 45 HTMLAllCollection::~HTMLAllCollection()
46 { 46 {
47 } 47 }
48 48
49 Element* HTMLAllCollection::namedItemWithIndex(const AtomicString& name, unsigne d index) const 49 Element* HTMLAllCollection::namedItemWithIndex(const AtomicString& name, unsigne d index) const
50 { 50 {
51 updateIdNameCache(); 51 updateIdNameCache();
52 52
53 if (Vector<Element*>* cache = idCache(name)) { 53 const NamedItemCache& cache = namedItemCache();
54 if (index < cache->size()) 54 if (Vector<Element*>* elements = cache.getElementsById(name)) {
55 return cache->at(index); 55 if (index < elements->size())
56 index -= cache->size(); 56 return elements->at(index);
57 index -= elements->size();
57 } 58 }
58 59
59 if (Vector<Element*>* cache = nameCache(name)) { 60 if (Vector<Element*>* elements = cache.getElementsByName(name)) {
60 if (index < cache->size()) 61 if (index < elements->size())
61 return cache->at(index); 62 return elements->at(index);
62 } 63 }
63 64
64 return 0; 65 return 0;
65 } 66 }
66 67
67 void HTMLAllCollection::namedGetter(const AtomicString& name, bool& returnValue0 Enabled, RefPtr<NodeList>& returnValue0, bool& returnValue1Enabled, RefPtr<Eleme nt>& returnValue1) 68 void HTMLAllCollection::namedGetter(const AtomicString& name, bool& returnValue0 Enabled, RefPtr<NodeList>& returnValue0, bool& returnValue1Enabled, RefPtr<Eleme nt>& returnValue1)
68 { 69 {
69 Vector<RefPtr<Element> > namedItems; 70 Vector<RefPtr<Element> > namedItems;
70 this->namedItems(name, namedItems); 71 this->namedItems(name, namedItems);
71 72
72 if (!namedItems.size()) 73 if (!namedItems.size())
73 return; 74 return;
74 75
75 if (namedItems.size() == 1) { 76 if (namedItems.size() == 1) {
76 returnValue1Enabled = true; 77 returnValue1Enabled = true;
77 returnValue1 = namedItems.at(0); 78 returnValue1 = namedItems.at(0);
78 return; 79 return;
79 } 80 }
80 81
81 // FIXME: HTML5 specification says this should be a HTMLCollection. 82 // FIXME: HTML5 specification says this should be a HTMLCollection.
82 // http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-in terfaces.html#htmlallcollection 83 // http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-in terfaces.html#htmlallcollection
83 returnValue0Enabled = true; 84 returnValue0Enabled = true;
84 returnValue0 = NamedNodesCollection::create(namedItems); 85 returnValue0 = NamedNodesCollection::create(namedItems);
85 } 86 }
86 87
87 } // namespace WebCore 88 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | Source/core/html/HTMLCollection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698