Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2150623002: Refactor: Extract a KeyboardHandler and CommandHandler from Background (Closed)

Created:
4 years, 5 months ago by David Tseng
Modified:
4 years, 5 months ago
Reviewers:
dmazzoni
CC:
aboxhall+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, oshima+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor: Extract a KeyboardHandler and CommandHandler from Background Besides the mechanical changes needed, some simplification of the mode change logic was done. These changes should have no functional effects. In addition, many commands that required a range in CommandHandler.onCommand were moved to the switch block not requiring a current range. This should be the only behavioral change introduced. BUG=625451 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/e451a40f0789251b6bebd1df69a00bc49dcac873 Cr-Commit-Position: refs/heads/master@{#405799}

Patch Set 1 : f #

Patch Set 2 : Fix test. #

Messages

Total messages: 15 (8 generated)
David Tseng
4 years, 5 months ago (2016-07-13 19:27:43 UTC) #6
dmazzoni
lgtm
4 years, 5 months ago (2016-07-13 23:46:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150623002/40001
4 years, 5 months ago (2016-07-15 16:31:03 UTC) #9
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-15 16:31:04 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 5 months ago (2016-07-15 18:36:52 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 18:37:13 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 18:38:32 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e451a40f0789251b6bebd1df69a00bc49dcac873
Cr-Commit-Position: refs/heads/master@{#405799}

Powered by Google App Engine
This is Rietveld 408576698