chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js - Issue 2150623002: Refactor: Extract a KeyboardHandler and CommandHandler from Background

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js

Issue 2150623002: Refactor: Extract a KeyboardHandler and CommandHandler from Background (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs ('k') | chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js

index 1845335b738fd447c32648f321bb6564194f7700..c2eb5bd55dc8469392a961d41f695ec5f05be52e 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js

@@ -310,10 +310,9 @@ Panel.onOpenMenus = function(opt_event, opt_activateMenuTitle) {

binding.title,

binding.keySeq,

function() {

- var bkgnd =

- chrome.extension.

- getBackgroundPage()['ChromeVoxState']['instance'];

- bkgnd['onGotCommand'](binding.command);

+ var CommandHandler =

+ chrome.extension.getBackgroundPage()['CommandHandler'];

+ CommandHandler['onCommand'](binding.command);

});

}

}, this));