Prevent hiding a toast during animation

ash/common/system/toast/toast_overlay.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/system/toast/toast_overlay.h"
 
 #include "ash/common/shelf/wm_shelf.h"
 #include "ash/common/shell_window_ids.h"
 #include "ash/common/wm_lookup.h"
 #include "ash/common/wm_root_window_controller.h"
@@ skipping 235 matching lines @@
 ToastOverlay::~ToastOverlay() {
   overlay_widget_->Close();
 }
 
 void ToastOverlay::Show(bool visible) {
   if (overlay_widget_->GetLayer()->GetTargetVisibility() == visible)
     return;
 
   ui::LayerAnimator* animator = overlay_widget_->GetLayer()->GetAnimator();
   DCHECK(animator);
+  if (animator->is_animating())
+    return;

[oshima, 2016/07/14 13:18:31]

won't his also prevent showing during hiding animation? Is it ok?

[yoshiki, 2016/07/15 02:38:30]

It doesn't happen, since a toast overlay instance is not reused. The toast
manager instanciates new ToastOverlay after hiding animation of previous toast.

I added DCHECK.

 
   base::TimeDelta original_duration = animator->GetTransitionDuration();
   ui::ScopedLayerAnimationSettings animation_settings(animator);
   // ScopedLayerAnimationSettings ctor chanes the transition duration, so change
   // back it to the original value (should be zero).
   animation_settings.SetTransitionDuration(original_duration);
 
   animation_settings.AddObserver(this);
 
   if (visible) {
@@ skipping 23 matching lines @@
 
 views::Widget* ToastOverlay::widget_for_testing() {
   return overlay_widget_.get();
 }
 
 void ToastOverlay::ClickDismissButtonForTesting(const ui::Event& event) {
   overlay_view_->button()->NotifyClick(event);
 }
 
 }  // namespace ash