Added policy device id validation similar to the existing DM token validation.

Added policy device id validation similar to the existing DM token validation.
BUG=360708
Committed: https://crrev.com/ed0d60b78f377e9279c1ceb3d374ef958fa9903a
Cr-Commit-Position: refs/heads/master@{#405719}

[ljusten (tachyonic), 2016-07-13 16:55:25]

ljusten@chromium.org changed reviewers:
+ atwilson@google.com

[ljusten (tachyonic), 2016-07-13 16:55:26]

Please review the device id validation code we talked about today.

[ljusten (tachyonic), 2016-07-13 16:55:34]

The CQ bit was checked by ljusten@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 16:56:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 17:40:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 17:40:39]

Dry run: This issue passed the CQ dry run.

[ljusten (tachyonic), 2016-07-14 14:43:50]

Description was changed from

==========
Added policy device id validation similar to the existing DM token validation.
BUG=360708
==========

to

==========
Added policy device id validation similar to the existing DM token validation.
BUG=360708
==========

[ljusten (tachyonic), 2016-07-14 14:43:50]

ljusten@chromium.org changed reviewers:
+ atwilson@chromium.org
- atwilson@google.com

[Andrew T Wilson (Slow), 2016-07-14 15:03:51]

LGTM once you remove the changes to policy_templates.json from this CL. Nice
work!

https://codereview.chromium.org/2150603002/diff/1/components/policy/resources...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/2150603002/diff/1/components/policy/resources...
components/policy/resources/policy_templates.json:4862: 'caption': '''Send
network packets to the management server to monitor online status''',
I think somehow some diffs from a different bug fix snuck in this CL - you
should take it out.

[ljusten (tachyonic), 2016-07-14 16:34:59]

The CQ bit was checked by ljusten@chromium.org

[ljusten (tachyonic), 2016-07-14 16:34:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
atwilson@chromium.org
Link to the patchset: https://codereview.chromium.org/2150603002/#ps20001
(title: "Added policy device id validation similar to the existing DM token
validation. BUG: 360708")

[commit-bot: I haz the power, 2016-07-14 16:35:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ljusten (tachyonic), 2016-07-14 16:35:33]

The CQ bit was unchecked by ljusten@chromium.org

[ljusten (tachyonic), 2016-07-15 07:25:02]

The CQ bit was checked by ljusten@chromium.org

[commit-bot: I haz the power, 2016-07-15 07:25:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 08:02:29]

Description was changed from

==========
Added policy device id validation similar to the existing DM token validation.
BUG=360708
==========

to

==========
Added policy device id validation similar to the existing DM token validation.
BUG=360708
==========

[commit-bot: I haz the power, 2016-07-15 08:02:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-15 08:04:16]

Description was changed from

==========
Added policy device id validation similar to the existing DM token validation.
BUG=360708
==========

to

==========
Added policy device id validation similar to the existing DM token validation.
BUG=360708

Committed: https://crrev.com/ed0d60b78f377e9279c1ceb3d374ef958fa9903a
Cr-Commit-Position: refs/heads/master@{#405719}
==========

[commit-bot: I haz the power, 2016-07-15 08:04:17]

Patchset 2 (id:??) landed as
https://crrev.com/ed0d60b78f377e9279c1ceb3d374ef958fa9903a
Cr-Commit-Position: refs/heads/master@{#405719}

[michaelpg, 2016-07-15 19:54:36]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2153613003/ by michaelpg@chromium.org.

The reason for reverting is: Crashes in PFQ information builders in
login_OwnershipNotRetaken VM/HWtests.

[31587:31603:0715/084815:ERROR:cloud_policy_validator.cc(472)] Empty device id
encountered - expected: 

crbug.com/628720.